* [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled
@ 2022-04-29 14:36 Pali Rohár
2022-04-29 20:53 ` Sean Anderson
2022-05-05 23:39 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2022-04-29 14:36 UTC (permalink / raw)
To: Patrick Delaunay, Simon Glass; +Cc: u-boot
drivers/misc/fs_loader.c: In function ‘mount_ubifs’:
drivers/misc/fs_loader.c:46:12: warning: implicit declaration of function ‘ubi_part’ [-Wimplicit-function-declaration]
int ret = ubi_part(mtdpart, NULL);
^~~~~~~~
drivers/misc/fs_loader.c:53:9: warning: implicit declaration of function ‘cmd_ubifs_mount’ [-Wimplicit-function-declaration]
return cmd_ubifs_mount(ubivol);
^~~~~~~~~~~~~~~
drivers/misc/fs_loader.c: In function ‘umount_ubifs’:
drivers/misc/fs_loader.c:58:9: warning: implicit declaration of function ‘cmd_ubifs_umount’ [-Wimplicit-function-declaration]
return cmd_ubifs_umount();
^~~~~~~~~~~~~~~~
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/misc/fs_loader.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
index 0139bd66ba76..5b4d03639c35 100644
--- a/drivers/misc/fs_loader.c
+++ b/drivers/misc/fs_loader.c
@@ -20,6 +20,10 @@
#include <malloc.h>
#include <spl.h>
+#ifdef CONFIG_CMD_UBIFS
+#include <ubi_uboot.h>
+#endif
+
DECLARE_GLOBAL_DATA_PTR;
/**
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled
2022-04-29 14:36 [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled Pali Rohár
@ 2022-04-29 20:53 ` Sean Anderson
2022-05-05 23:39 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Anderson @ 2022-04-29 20:53 UTC (permalink / raw)
To: Pali Rohár, Patrick Delaunay, Simon Glass; +Cc: u-boot
On 4/29/22 10:36 AM, Pali Rohár wrote:
> drivers/misc/fs_loader.c: In function ‘mount_ubifs’:
> drivers/misc/fs_loader.c:46:12: warning: implicit declaration of function ‘ubi_part’ [-Wimplicit-function-declaration]
> int ret = ubi_part(mtdpart, NULL);
> ^~~~~~~~
> drivers/misc/fs_loader.c:53:9: warning: implicit declaration of function ‘cmd_ubifs_mount’ [-Wimplicit-function-declaration]
> return cmd_ubifs_mount(ubivol);
> ^~~~~~~~~~~~~~~
> drivers/misc/fs_loader.c: In function ‘umount_ubifs’:
> drivers/misc/fs_loader.c:58:9: warning: implicit declaration of function ‘cmd_ubifs_umount’ [-Wimplicit-function-declaration]
> return cmd_ubifs_umount();
> ^~~~~~~~~~~~~~~~
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/misc/fs_loader.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 0139bd66ba76..5b4d03639c35 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -20,6 +20,10 @@
> #include <malloc.h>
> #include <spl.h>
>
> +#ifdef CONFIG_CMD_UBIFS
> +#include <ubi_uboot.h>
> +#endif
> +
> DECLARE_GLOBAL_DATA_PTR;
>
> /**
>
Can we include this unconditionally?
--Sean
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled
2022-04-29 14:36 [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled Pali Rohár
2022-04-29 20:53 ` Sean Anderson
@ 2022-05-05 23:39 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-05-05 23:39 UTC (permalink / raw)
To: Pali Rohár; +Cc: Patrick Delaunay, Simon Glass, u-boot
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Fri, Apr 29, 2022 at 04:36:23PM +0200, Pali Rohár wrote:
> drivers/misc/fs_loader.c: In function ‘mount_ubifs’:
> drivers/misc/fs_loader.c:46:12: warning: implicit declaration of function ‘ubi_part’ [-Wimplicit-function-declaration]
> int ret = ubi_part(mtdpart, NULL);
> ^~~~~~~~
> drivers/misc/fs_loader.c:53:9: warning: implicit declaration of function ‘cmd_ubifs_mount’ [-Wimplicit-function-declaration]
> return cmd_ubifs_mount(ubivol);
> ^~~~~~~~~~~~~~~
> drivers/misc/fs_loader.c: In function ‘umount_ubifs’:
> drivers/misc/fs_loader.c:58:9: warning: implicit declaration of function ‘cmd_ubifs_umount’ [-Wimplicit-function-declaration]
> return cmd_ubifs_umount();
> ^~~~~~~~~~~~~~~~
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-05 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-29 14:36 [PATCH] misc: fs_loader: Fix compile warnings when CONFIG_CMD_UBIFS is enabled Pali Rohár
2022-04-29 20:53 ` Sean Anderson
2022-05-05 23:39 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox