From: "Marek Behún" <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>, u-boot@lists.denx.de
Subject: Re: [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets
Date: Sun, 1 May 2022 20:53:51 +0200 [thread overview]
Message-ID: <20220501205351.5284ef72@thinkpad> (raw)
In-Reply-To: <20220501145231.sdcruc7xskzq3un3@pali>
On Sun, 1 May 2022 16:52:31 +0200
Pali Rohár <pali@kernel.org> wrote:
> On Friday 08 April 2022 11:00:24 Pali Rohár wrote:
> > On Wednesday 06 April 2022 21:31:18 Marek Behún wrote:
> > > On Wed, 6 Apr 2022 11:39:34 +0200
> > > Pali Rohár <pali@kernel.org> wrote:
> > >
> > > > U-Boot for Turris Omnia is always compiled with MMC, SCSI and USB support,
> > > > so always enable macros for booting from these devices.
> > >
> > > This is not true. Attaching config where scsi is disabled.
> > >
> > > If we want to enforce MMC, SCSI and USB, we should add
> > > select MMC
> > > and others to Kconfig under TURRIS_OMNIA. But do we want to enfore
> > > these?
> > >
> > > Marek
> >
> > IIRC macro BOOT_TARGET_DEVICES just defines default values for ENV. So
> > in default ENV would be macros for booting from SCSI, MMC and USB
> > targets. Which means that if you call saveenv on U-Boot compiled with
> > all these options and then replace U-Boot with the one without e.g. MMC
> > support, it does not replace env variables for MMC booting.
> >
> > Anyway, does not defining e.g. SCSI booting env variables on U-Boot
> > without SCSI support result in the same state as defining SCSI booting
> > env variables on U-Boot with SCSI support with disconnected SCSI
> > controllers or disks? In both cases there would be no SCSI suitable boot
> > device.
>
> So, any issues with it?
No. If this cannot cause compilation failures, then I am okay with it.
next prev parent reply other threads:[~2022-05-01 18:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:39 [PATCH 1/5] arm: mvebu: turris_omnia: Fix RESET button message Pali Rohár
2022-04-06 9:39 ` [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV Pali Rohár
2022-04-06 19:24 ` Marek Behún
2022-05-02 5:48 ` Stefan Roese
2022-05-02 15:41 ` Stefan Roese
2022-04-06 9:39 ` [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets Pali Rohár
2022-04-06 19:31 ` Marek Behún
2022-04-08 9:00 ` Pali Rohár
2022-05-01 14:52 ` Pali Rohár
2022-05-01 18:53 ` Marek Behún [this message]
2022-05-02 15:42 ` Stefan Roese
2022-04-06 9:39 ` [PATCH 4/5] arm: mvebu: turris_omnia: Add NVMe to " Pali Rohár
2022-04-06 19:32 ` Marek Behún
2022-05-02 15:42 ` Stefan Roese
2022-04-06 9:39 ` [PATCH 5/5] arm: mvebu: turris_mox: Add NVMe and SCSI " Pali Rohár
2022-04-06 19:33 ` Marek Behún
2022-05-02 15:42 ` Stefan Roese
2022-04-06 19:23 ` [PATCH 1/5] arm: mvebu: turris_omnia: Fix RESET button message Marek Behún
2022-05-02 15:41 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220501205351.5284ef72@thinkpad \
--to=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox