From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03028C433F5 for ; Sun, 1 May 2022 18:53:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6714683D07; Sun, 1 May 2022 20:53:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="uyB4nmmY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE54083F05; Sun, 1 May 2022 20:53:55 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2087C83BBF for ; Sun, 1 May 2022 20:53:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPS id D6F3913FD1B; Sun, 1 May 2022 20:53:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1651431232; bh=gALCsTwY3ztGZvCU4h7FtwFShmbuLBjesSJ3WyzoM/c=; h=Date:From:To:Cc:Subject:From; b=uyB4nmmY5eCS8K6uHDEK3mQrDYS7q7h+DNPC3k3xmoV1HLbQ/P/CzOZgJzc4X6WYX bicqiXmmQc9jwf/3VfPlJUQgS3ekNV+0azFv1Z5rn2VDB3ENti+p9MpwT7xJlgrEFn npjpQq5J5frFo1LAqgiE8SjWerSOQ5YRG1KJ5e5c= Date: Sun, 1 May 2022 20:53:51 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets Message-ID: <20220501205351.5284ef72@thinkpad> In-Reply-To: <20220501145231.sdcruc7xskzq3un3@pali> References: <20220406093936.8854-1-pali@kernel.org> <20220406093936.8854-3-pali@kernel.org> <20220406213118.763b6ebf@thinkpad> <20220408090024.ct4w3gjcnhro4iun@pali> <20220501145231.sdcruc7xskzq3un3@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, 1 May 2022 16:52:31 +0200 Pali Roh=C3=A1r wrote: > On Friday 08 April 2022 11:00:24 Pali Roh=C3=A1r wrote: > > On Wednesday 06 April 2022 21:31:18 Marek Beh=C3=BAn wrote: =20 > > > On Wed, 6 Apr 2022 11:39:34 +0200 > > > Pali Roh=C3=A1r wrote: > > > =20 > > > > U-Boot for Turris Omnia is always compiled with MMC, SCSI and USB s= upport, > > > > so always enable macros for booting from these devices. =20 > > >=20 > > > This is not true. Attaching config where scsi is disabled. > > >=20 > > > If we want to enforce MMC, SCSI and USB, we should add > > > select MMC > > > and others to Kconfig under TURRIS_OMNIA. But do we want to enfore > > > these? > > >=20 > > > Marek =20 > >=20 > > IIRC macro BOOT_TARGET_DEVICES just defines default values for ENV. So > > in default ENV would be macros for booting from SCSI, MMC and USB > > targets. Which means that if you call saveenv on U-Boot compiled with > > all these options and then replace U-Boot with the one without e.g. MMC > > support, it does not replace env variables for MMC booting. > >=20 > > Anyway, does not defining e.g. SCSI booting env variables on U-Boot > > without SCSI support result in the same state as defining SCSI booting > > env variables on U-Boot with SCSI support with disconnected SCSI > > controllers or disks? In both cases there would be no SCSI suitable boot > > device. =20 >=20 > So, any issues with it? No. If this cannot cause compilation failures, then I am okay with it.