From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2B77C433F5 for ; Mon, 9 May 2022 23:43:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD8DC83F26; Tue, 10 May 2022 01:43:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A38D283F27; Tue, 10 May 2022 01:43:29 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 2048983B74 for ; Tue, 10 May 2022 01:43:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3276212FC; Mon, 9 May 2022 16:43:26 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B8393F5A1; Mon, 9 May 2022 16:43:25 -0700 (PDT) Date: Tue, 10 May 2022 00:43:09 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Tom Rini Subject: Re: [PATCH 1/2] sunxi: Remove obsolete Kconfig selections Message-ID: <20220510004309.6d9b9e50@slackpad.lan> In-Reply-To: <20220509051055.40232-1-samuel@sholland.org> References: <20220509051055.40232-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, 9 May 2022 00:10:54 -0500 Samuel Holland wrote: > ARCH_SUNXI selects DM_SERIAL, so the condition can never be satisfied. True, and even if !DM_SERIAL would be a thing, it looks odd to begin with. > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > arch/arm/mach-sunxi/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 1f43b25324..ee606c5bbc 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -207,7 +207,6 @@ config MACH_SUN5I > select PHY_SUN4I_USB > select SUNXI_GEN_SUN4I > select SUPPORT_SPL > - imply CONS_INDEX_2 if !DM_SERIAL > imply SPL_SYS_I2C_LEGACY > imply SYS_I2C_LEGACY > > @@ -255,7 +254,6 @@ config MACH_SUN8I_A23 > select SUPPORT_SPL > select SYS_I2C_SUN8I_RSB > select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT > - imply CONS_INDEX_5 if !DM_SERIAL > > config MACH_SUN8I_A33 > bool "sun8i (Allwinner A33)" > @@ -270,7 +268,6 @@ config MACH_SUN8I_A33 > select SUPPORT_SPL > select SYS_I2C_SUN8I_RSB > select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT > - imply CONS_INDEX_5 if !DM_SERIAL > > config MACH_SUN8I_A83T > bool "sun8i (Allwinner A83T)"