public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: "Joe Hershberger" <joe.hershberger@ni.com>,
	"Ramon Fried" <rfried.dev@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	u-boot@lists.denx.de, "Stefano Babic" <sbabic@denx.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	"Marek Behún" <marek.behun@nic.cz>
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	Anatolij Gustschin <agust@denx.de>,
	Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH 2/8] net: dsa: move cpu port probe to dsa_post_probe
Date: Wed, 11 May 2022 17:19:57 -0700	[thread overview]
Message-ID: <20220512002003.16886-3-tharvey@gateworks.com> (raw)
In-Reply-To: <20220512002003.16886-1-tharvey@gateworks.com>

In order to ensure that a DSA driver probe gets called before
dsa_ops->port_probe move the port_probe of the cpu_port to
a post-probe function.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
---
v2:
 - added Ramon's rb tag
---
 net/dsa-uclass.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c
index 9ff55a02fb23..07edc584daf3 100644
--- a/net/dsa-uclass.c
+++ b/net/dsa-uclass.c
@@ -466,8 +466,6 @@ static int dsa_pre_probe(struct udevice *dev)
 {
 	struct dsa_pdata *pdata = dev_get_uclass_plat(dev);
 	struct dsa_priv *priv = dev_get_uclass_priv(dev);
-	struct dsa_ops *ops = dsa_get_ops(dev);
-	int err;
 
 	priv->num_ports = pdata->num_ports;
 	priv->cpu_port = pdata->cpu_port;
@@ -480,6 +478,15 @@ static int dsa_pre_probe(struct udevice *dev)
 	uclass_find_device_by_ofnode(UCLASS_ETH, pdata->master_node,
 				     &priv->master_dev);
 
+	return 0;
+}
+
+static int dsa_post_probe(struct udevice *dev)
+{
+	struct dsa_priv *priv = dev_get_uclass_priv(dev);
+	struct dsa_ops *ops = dsa_get_ops(dev);
+	int err;
+
 	/* Simulate a probing event for the CPU port */
 	if (ops->port_probe) {
 		err = ops->port_probe(dev, priv->cpu_port,
@@ -489,13 +496,14 @@ static int dsa_pre_probe(struct udevice *dev)
 	}
 
 	return 0;
-}
+};
 
 UCLASS_DRIVER(dsa) = {
 	.id = UCLASS_DSA,
 	.name = "dsa",
 	.post_bind = dsa_post_bind,
 	.pre_probe = dsa_pre_probe,
+	.post_probe = dsa_post_probe,
 	.per_device_auto = sizeof(struct dsa_priv),
 	.per_device_plat_auto = sizeof(struct dsa_pdata),
 	.per_child_plat_auto = sizeof(struct dsa_port_pdata),
-- 
2.17.1


  parent reply	other threads:[~2022-05-12  0:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  0:19 [PATCH v2 0/8] Add MV88E61xx DSA driver and use on gwventana Tim Harvey
2022-05-12  0:19 ` [PATCH 1/8] net: mdio-uclass: scan for dm mdio children on post-bind Tim Harvey
2022-05-12  0:19 ` Tim Harvey [this message]
2022-05-18 14:30   ` [PATCH 2/8] net: dsa: move cpu port probe to dsa_post_probe Vladimir Oltean
2022-05-12  0:19 ` [PATCH 3/8] net: dsa: ensure dsa driver has proper ops Tim Harvey
2022-05-18 14:31   ` Vladimir Oltean
2022-05-12  0:19 ` [PATCH 4/8] net: dsa: allow rcv() and xmit() to be optional Tim Harvey
2022-05-18 14:31   ` Vladimir Oltean
2022-05-12  0:20 ` [PATCH 5/8] net: ksz9477: remove unnecessary xmit and recv functions Tim Harvey
2022-05-18 14:30   ` Vladimir Oltean
2022-05-12  0:20 ` [PATCH 6/8] net: fec: add support for DM_MDIO Tim Harvey
2022-05-12  0:20 ` [PATCH 7/8] net: add MV88E61xx DSA driver Tim Harvey
2022-05-18 14:33   ` Vladimir Oltean
2022-05-12  0:20 ` [PATCH 8/8] board: gw_ventana: enable MV88E61XX DSA support Tim Harvey
2022-05-18 14:41   ` Vladimir Oltean
2022-05-18 16:15     ` Tim Harvey
2022-05-19 13:15       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220512002003.16886-3-tharvey@gateworks.com \
    --to=tharvey@gateworks.com \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=agust@denx.de \
    --cc=festevam@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=marek.behun@nic.cz \
    --cc=rfried.dev@gmail.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox