From: "Marek Behún" <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] mtd: mtdpart: Change size type from fdt_addr_t to fdt_size_t
Date: Sun, 15 May 2022 12:21:56 +0200 [thread overview]
Message-ID: <20220515122156.09cd7401@thinkpad> (raw)
In-Reply-To: <20220513202451.3283-1-pali@kernel.org>
On Fri, 13 May 2022 22:24:51 +0200
Pali Rohár <pali@kernel.org> wrote:
> Set correct type for 3rd argument of ofnode_get_addr_size_index_notrans()
> function. It expects fdt_size_t * and not fdt_addr_t *.
>
> When these two types do not have same size then U-Boot throw compile
> warning:
>
> drivers/mtd/mtdpart.c: In function ‘add_mtd_partitions_of’:
> drivers/mtd/mtdpart.c:906:57: warning: passing argument 3 of ‘ofnode_get_addr_size_index_notrans’ from incompatible pointer type [-Wincompatible-pointer-types]
> offset = ofnode_get_addr_size_index_notrans(child, 0, &size);
> ^~~~~
> In file included from include/dm/device.h:13,
> from include/linux/mtd/mtd.h:26,
> from include/ubi_uboot.h:28,
> from drivers/mtd/mtdpart.c:27:
> include/dm/ofnode.h:530:25: note: expected ‘fdt_size_t *’ {aka ‘long long unsigned int *’} but argument is of type ‘fdt_addr_t *’ {aka ‘long unsigned int *’}
> fdt_size_t *size);
> ~~~~~~~~~~~~^~~~
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
next prev parent reply other threads:[~2022-05-15 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 20:24 [PATCH] mtd: mtdpart: Change size type from fdt_addr_t to fdt_size_t Pali Rohár
2022-05-15 10:21 ` Marek Behún [this message]
2022-06-07 16:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515122156.09cd7401@thinkpad \
--to=marek.behun@nic.cz \
--cc=jagan@amarulasolutions.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox