From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF643C433FE for ; Fri, 20 May 2022 15:21:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A9A3283E51; Fri, 20 May 2022 17:21:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tZnpqSbX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5541D83E36; Fri, 20 May 2022 17:21:39 +0200 (CEST) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 196CA83E51 for ; Fri, 20 May 2022 17:21:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id k2so7152768qtp.1 for ; Fri, 20 May 2022 08:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mAJVxaOrTcrfGy9OHjM8xXvChj59ISAMy2RZ7ZvSZKw=; b=tZnpqSbXnH+7vk4xbdfOKfl8HLc5yXANaNiGXlFVnhXg5BYCJbqiEqbc6+FKdJHW2T E6E/vevw3VMtHBhUwKtz28/Gegwup+7B4iFRtE72XtAEBMzUakrsQj4UPgJCdjZAN3qk pAyKQZyEZumvstNj8Y0j7/uzZQutlORgPOSDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mAJVxaOrTcrfGy9OHjM8xXvChj59ISAMy2RZ7ZvSZKw=; b=7c8fdyknSWMymVBuANoUIJxCfRmu1i/AFqToM6OkJlgpceA7MVgfj+0fo8W5dx1tMB 3FqQk7sVpGyxMFku6cDNkI8DhyqtS5LjVeWqEtaZDrqVZImPm0swlmWgAwhmzdsf8JMM 0bfjzmGVtMbeVYsahvUEd+MgY3+ygnmH5IDObrs7vZ/LV0Aa8oDM+A+y9X5ELhnb5nfE cye3QSgz4CNFH9DdQa6ygiScMsZMGmlS5LAGp6tJvIBOJ71Yu8r9TcG4ss1VTB3m/hoc 06BxjMO/zyu9Da9s6RQFOgUJ8FmVkPLESY1foew9v05VdntJRCseoAMXTAb0KWFyZnVy eRVA== X-Gm-Message-State: AOAM532nBqzBGJ3DW0YJ55olB9VSINIPm6h+UPjpKnVUO9ArgZ/MtWMK bKEQKJyqHfvtEUCXPYX4+PBDpw== X-Google-Smtp-Source: ABdhPJw//F3a3BhGyTGS3tsDP21gbLshY42yxaXnPAC48UDmf+B24q50mR9MsCgAAFm94yRLRJFnhA== X-Received: by 2002:ac8:5806:0:b0:2f3:e618:7d42 with SMTP id g6-20020ac85806000000b002f3e6187d42mr7993170qtg.665.1653060090994; Fri, 20 May 2022 08:21:30 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-200-14.ec.res.rr.com. [65.184.200.14]) by smtp.gmail.com with ESMTPSA id k18-20020ac86052000000b002f8f547d12asm3179014qtm.32.2022.05.20.08.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 08:21:30 -0700 (PDT) Date: Fri, 20 May 2022 11:21:27 -0400 From: Tom Rini To: "Peng Fan (OSS)" Cc: sbabic@denx.de, festevam@gmail.com, ariel.dalessandro@collabora.com, michael@amarulasolutions.com, tharvey@gateworks.com, sjg@chromium.org, alpernebiyasak@gmail.com, marek.behun@nic.cz, pali@kernel.org, sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com, u-boot@lists.denx.de, Peng Fan Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 Message-ID: <20220520152127.GC13239@bill-the-cat> References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="da4uJneut+ArUgXk" Content-Disposition: inline In-Reply-To: <20220520141048.20034-2-peng.fan@oss.nxp.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --da4uJneut+ArUgXk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan >=20 > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > only used on X86 for now, so guard it with X86, otherwise build break > if we use BINMAN_SYMBOLS on i.MX. >=20 > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > Signed-off-by: Peng Fan > --- > common/spl/spl.c | 8 ++++++-- > common/spl/spl_ram.c | 4 ++++ > 2 files changed, 10 insertions(+), 2 deletions(-) I think we long term need to figure this out and address it so LTO works. But for now can you please guard this with a test on LTO instead, so it's clear where the problem is? --=20 Tom --da4uJneut+ArUgXk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKHsfcACgkQFHw5/5Y0 tyx6CAv9ES+0bo0FWpqNDNGDqny/sRdQviXADoMG3onUYtEpYUFzU3VJ6tChAr9Y XUtF4hOYOhH+b6G5QXASFVKhnArDnKk6nNrUG8XmI4jmo+XbIcMNVkRehKywMIYL oeMWmsCIXoMAzAP4oYRpNaTCQ4YincvFBakQainmwhg1zrgWkPdo7Yb8NZRge2jQ VmbiT0SCvAnfmFbRNRaASTE62IPx3pEGYgfWQ79wqFqrWgO6rhEo6blhqETUA/Rn fNprbncomdNyhnW8vxI+E4pvCuTqRQpt5edoeU75k/5vDSh8XtclD/sqL9b+ZZ1V 8e+Ut8bpPkQZj3Rt7qpOeBfoHZvnCSqY/9RvKlZuFgQV0vMnkdGfEr/cR9b+pjfd KVVQkfyEi+QAhNwkJoME2De9nMIqVnBEGX/2H7vUyRe7V+hP0x1/UAf87QOjDcHy HiPJzTgZoAZ6LguUXWikR60NgWUuvG9MoR05wI4zZWNEXaTOeAE32ZJZHV1Y0KVy UZpSZJtN =x3Ao -----END PGP SIGNATURE----- --da4uJneut+ArUgXk--