Re: [PATCH] arm: socfpga: Add the terasic de10-standard board

Humberto Naves
2022-05-23T13:21:51Z

Hi Marek,

Thanks for the quick review!

> Doesn't the PLL config also come from quartus ? It should all come from
> it. See doc/README.socfpga

My mistake, I will update the patch using all the files created by the
bsp-create-settings.

> I think a lot of those board/config-specific copyright messages could
> use an update, I think they should be assigned to you. Please do a quick
> V2 with that change. Besides that:

Please advise what I should do there. For this particular board I adapted
the code from the de10-nano board, which already had these copyright
messages.

Best regards,

On Sat, May 21, 2022 at 10:06 PM Marek Vasut <marex@denx.de> wrote:
>
> On 5/21/22 19:32, Humberto Naves wrote:
> > Used the de10-nano files as templates for the de10-standard board.
> > Changed the iocsr_config.h and pinmux_config.h based on the handoff
> > files generated by quartus. Finally, the pll_config.h was copied
> > from the altera cyclone5-socdk board.
>
> Doesn't the PLL config also come from quartus ? It should all come from
> it. See doc/README.socfpga
>
> > Signed-off-by: Humberto Naves <hsnaves@gmail.com>
> > Cc: Marek Vasut <marex@denx.de>
>
> I think a lot of those board/config-specific copyright messages could
> use an update, I think they should be assigned to you. Please do a quick
> V2 with that change. Besides that:
>
> Reviewed-by: Marek Vasut <marex@denx.de>