* [PATCH] net: Add missing PCI dependency for CONFIG_E1000
@ 2022-05-23 8:41 Pali Rohár
2022-05-24 9:32 ` Ramon Fried
2022-05-24 17:12 ` Sean Anderson
0 siblings, 2 replies; 6+ messages in thread
From: Pali Rohár @ 2022-05-23 8:41 UTC (permalink / raw)
To: Joe Hershberger, Ramon Fried; +Cc: u-boot
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 7fe0e00649cf..84d859c21eb8 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
config E1000
bool "Intel PRO/1000 Gigabit Ethernet support"
+ depends on PCI
help
This driver supports Intel(R) PRO/1000 gigabit ethernet family of
adapters. For more information on how to identify your adapter, go
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
2022-05-23 8:41 [PATCH] net: Add missing PCI dependency for CONFIG_E1000 Pali Rohár
@ 2022-05-24 9:32 ` Ramon Fried
2022-05-24 17:12 ` Sean Anderson
1 sibling, 0 replies; 6+ messages in thread
From: Ramon Fried @ 2022-05-24 9:32 UTC (permalink / raw)
To: Pali Rohár; +Cc: Joe Hershberger, U-Boot Mailing List
On Mon, May 23, 2022 at 11:42 AM Pali Rohár <pali@kernel.org> wrote:
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 7fe0e00649cf..84d859c21eb8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
>
> config E1000
> bool "Intel PRO/1000 Gigabit Ethernet support"
> + depends on PCI
> help
> This driver supports Intel(R) PRO/1000 gigabit ethernet family of
> adapters. For more information on how to identify your adapter, go
> --
> 2.20.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
2022-05-23 8:41 [PATCH] net: Add missing PCI dependency for CONFIG_E1000 Pali Rohár
2022-05-24 9:32 ` Ramon Fried
@ 2022-05-24 17:12 ` Sean Anderson
2022-05-24 17:16 ` Pali Rohár
1 sibling, 1 reply; 6+ messages in thread
From: Sean Anderson @ 2022-05-24 17:12 UTC (permalink / raw)
To: Pali Rohár, Joe Hershberger, Ramon Fried; +Cc: u-boot
Hi Pali,
On 5/23/22 4:41 AM, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 7fe0e00649cf..84d859c21eb8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
>
> config E1000
> bool "Intel PRO/1000 Gigabit Ethernet support"
> + depends on PCI
> help
> This driver supports Intel(R) PRO/1000 gigabit ethernet family of
> adapters. For more information on how to identify your adapter, go
>
This appears to be a duplicate of [1].
[1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.com/
--Sean
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
2022-05-24 17:12 ` Sean Anderson
@ 2022-05-24 17:16 ` Pali Rohár
2022-05-24 17:32 ` Sean Anderson
0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2022-05-24 17:16 UTC (permalink / raw)
To: Sean Anderson; +Cc: Joe Hershberger, Ramon Fried, u-boot
On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
> Hi Pali,
>
> On 5/23/22 4:41 AM, Pali Rohár wrote:
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > drivers/net/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 7fe0e00649cf..84d859c21eb8 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
> >
> > config E1000
> > bool "Intel PRO/1000 Gigabit Ethernet support"
> > + depends on PCI
> > help
> > This driver supports Intel(R) PRO/1000 gigabit ethernet family of
> > adapters. For more information on how to identify your adapter, go
> >
>
> This appears to be a duplicate of [1].
>
> [1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.com/
>
> --Sean
Interesting... this is my second duplicate patch this week.
Any idea why above patch was not accepted yet?
I'm just testing U-Boot builds and I hit the same issue in dependency
graph.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
2022-05-24 17:16 ` Pali Rohár
@ 2022-05-24 17:32 ` Sean Anderson
2022-05-25 12:59 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Sean Anderson @ 2022-05-24 17:32 UTC (permalink / raw)
To: Pali Rohár; +Cc: Joe Hershberger, Ramon Fried, u-boot, Tom Rini
On 5/24/22 1:16 PM, Pali Rohár wrote:
> On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
>> Hi Pali,
>>
>> On 5/23/22 4:41 AM, Pali Rohár wrote:
>> > Signed-off-by: Pali Rohár <pali@kernel.org>
>> > ---
>> > drivers/net/Kconfig | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> > index 7fe0e00649cf..84d859c21eb8 100644
>> > --- a/drivers/net/Kconfig
>> > +++ b/drivers/net/Kconfig
>> > @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
>> >
>> > config E1000
>> > bool "Intel PRO/1000 Gigabit Ethernet support"
>> > + depends on PCI
>> > help
>> > This driver supports Intel(R) PRO/1000 gigabit ethernet family of
>> > adapters. For more information on how to identify your adapter, go
>> >
>>
>> This appears to be a duplicate of [1].
>>
>> [1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.com/
>>
>> --Sean
>
> Interesting... this is my second duplicate patch this week.
>
> Any idea why above patch was not accepted yet?
Looks like Ramon has not done a pull request since mid April [1]. Though
based on the past pattern, it seems like he just makes one PR each release.
Perhaps Tom can pick this up?
[1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLDzxacXQ@mail.gmail.com/
--Sean
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
2022-05-24 17:32 ` Sean Anderson
@ 2022-05-25 12:59 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2022-05-25 12:59 UTC (permalink / raw)
To: Sean Anderson; +Cc: Pali Rohár, Joe Hershberger, Ramon Fried, u-boot
[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]
On Tue, May 24, 2022 at 01:32:08PM -0400, Sean Anderson wrote:
>
>
> On 5/24/22 1:16 PM, Pali Rohár wrote:
> > On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
> >> Hi Pali,
> >>
> >> On 5/23/22 4:41 AM, Pali Rohár wrote:
> >> > Signed-off-by: Pali Rohár <pali@kernel.org>
> >> > ---
> >> > drivers/net/Kconfig | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> >> > index 7fe0e00649cf..84d859c21eb8 100644
> >> > --- a/drivers/net/Kconfig
> >> > +++ b/drivers/net/Kconfig
> >> > @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
> >> >
> >> > config E1000
> >> > bool "Intel PRO/1000 Gigabit Ethernet support"
> >> > + depends on PCI
> >> > help
> >> > This driver supports Intel(R) PRO/1000 gigabit ethernet family of
> >> > adapters. For more information on how to identify your adapter, go
> >> >
> >>
> >> This appears to be a duplicate of [1].
> >>
> >> [1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.com/
> >>
> >> --Sean
> >
> > Interesting... this is my second duplicate patch this week.
> >
> > Any idea why above patch was not accepted yet?
>
> Looks like Ramon has not done a pull request since mid April [1]. Though
> based on the past pattern, it seems like he just makes one PR each release.
> Perhaps Tom can pick this up?
>
> [1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLDzxacXQ@mail.gmail.com/
Sure. It didn't stand out as a critical thing so I was assuming at the
time it would come in eventually. I've put it in my bundle of stuff to
not forget.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-25 12:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 8:41 [PATCH] net: Add missing PCI dependency for CONFIG_E1000 Pali Rohár
2022-05-24 9:32 ` Ramon Fried
2022-05-24 17:12 ` Sean Anderson
2022-05-24 17:16 ` Pali Rohár
2022-05-24 17:32 ` Sean Anderson
2022-05-25 12:59 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox