From: "Pali Rohár" <pali@kernel.org>
To: Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: [PATCH] TPL: Do not allow enabling TPL symbols for non-TPL builds
Date: Tue, 24 May 2022 11:03:38 +0200 [thread overview]
Message-ID: <20220524090338.8360-1-pali@kernel.org> (raw)
It does not make sense to enable TPL options when not building TPL binary.
So disallow selecting TPL options for non-TPL builds.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
common/Kconfig | 4 ++++
drivers/power/acpi_pmc/Kconfig | 1 +
lib/Kconfig | 3 ++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/common/Kconfig b/common/Kconfig
index 8e59dcef4b8b..ba59edd14673 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -89,10 +89,14 @@ config SPL_LOGLEVEL
endif
+if TPL
+
config TPL_LOGLEVEL
int
default LOGLEVEL
+endif
+
config VPL_LOGLEVEL
int "loglevel for VPL"
default LOGLEVEL
diff --git a/drivers/power/acpi_pmc/Kconfig b/drivers/power/acpi_pmc/Kconfig
index 8b712abc41e9..629acb071427 100644
--- a/drivers/power/acpi_pmc/Kconfig
+++ b/drivers/power/acpi_pmc/Kconfig
@@ -18,6 +18,7 @@ config SPL_ACPI_PMC
config TPL_ACPI_PMC
bool "Power Manager (x86 PMC) support in TPL"
+ depends on TPL
default y if ACPI_PMC
help
Enable support for an x86-style power-management controller which
diff --git a/lib/Kconfig b/lib/Kconfig
index 299381ac80d5..ef1c57a075f6 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -249,6 +249,7 @@ config SPL_TINY_MEMSET
config TPL_TINY_MEMSET
bool "Use a very small memset() in TPL"
+ depends on TPL
help
The faster memset() is the arch-specific one (if available) enabled
by CONFIG_USE_ARCH_MEMSET. If that is not enabled, we can still get
@@ -779,7 +780,7 @@ config TPL_OF_LIBFDT
config TPL_OF_LIBFDT_ASSUME_MASK
hex "Mask of conditions to assume for libfdt"
- depends on TPL_OF_LIBFDT || FIT
+ depends on TPL_OF_LIBFDT || (TPL && FIT)
default 0xff
help
Use this to change the assumptions made by libfdt in TPL about the
--
2.20.1
next reply other threads:[~2022-05-24 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 9:03 Pali Rohár [this message]
2022-06-08 12:51 ` [PATCH] TPL: Do not allow enabling TPL symbols for non-TPL builds Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524090338.8360-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox