From: Tom Rini <trini@konsulko.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Joe Hershberger" <joe.hershberger@ni.com>,
"Ramon Fried" <rfried.dev@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000
Date: Wed, 25 May 2022 08:59:09 -0400 [thread overview]
Message-ID: <20220525125909.GJ13239@bill-the-cat> (raw)
In-Reply-To: <504ad9c4-304c-6bd1-24c5-2efff1bb1858@seco.com>
[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]
On Tue, May 24, 2022 at 01:32:08PM -0400, Sean Anderson wrote:
>
>
> On 5/24/22 1:16 PM, Pali Rohár wrote:
> > On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:
> >> Hi Pali,
> >>
> >> On 5/23/22 4:41 AM, Pali Rohár wrote:
> >> > Signed-off-by: Pali Rohár <pali@kernel.org>
> >> > ---
> >> > drivers/net/Kconfig | 1 +
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> >> > index 7fe0e00649cf..84d859c21eb8 100644
> >> > --- a/drivers/net/Kconfig
> >> > +++ b/drivers/net/Kconfig
> >> > @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
> >> >
> >> > config E1000
> >> > bool "Intel PRO/1000 Gigabit Ethernet support"
> >> > + depends on PCI
> >> > help
> >> > This driver supports Intel(R) PRO/1000 gigabit ethernet family of
> >> > adapters. For more information on how to identify your adapter, go
> >> >
> >>
> >> This appears to be a duplicate of [1].
> >>
> >> [1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.anderson@seco.com/
> >>
> >> --Sean
> >
> > Interesting... this is my second duplicate patch this week.
> >
> > Any idea why above patch was not accepted yet?
>
> Looks like Ramon has not done a pull request since mid April [1]. Though
> based on the past pattern, it seems like he just makes one PR each release.
> Perhaps Tom can pick this up?
>
> [1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLDzxacXQ@mail.gmail.com/
Sure. It didn't stand out as a critical thing so I was assuming at the
time it would come in eventually. I've put it in my bundle of stuff to
not forget.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-05-25 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:41 [PATCH] net: Add missing PCI dependency for CONFIG_E1000 Pali Rohár
2022-05-24 9:32 ` Ramon Fried
2022-05-24 17:12 ` Sean Anderson
2022-05-24 17:16 ` Pali Rohár
2022-05-24 17:32 ` Sean Anderson
2022-05-25 12:59 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525125909.GJ13239@bill-the-cat \
--to=trini@konsulko.com \
--cc=joe.hershberger@ni.com \
--cc=pali@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=sean.anderson@seco.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox