From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAA12C433EF for ; Mon, 30 May 2022 10:00:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FC11843C7; Mon, 30 May 2022 12:00:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="OwqxfuHR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3CCDE8437D; Mon, 30 May 2022 12:00:32 +0200 (CEST) Received: from mail-wr1-x44a.google.com (mail-wr1-x44a.google.com [IPv6:2a00:1450:4864:20::44a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE3BC8437D for ; Mon, 30 May 2022 12:00:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=3vJWUYgYKBlUxFzH883BB381.zB9H-yBBG85FGF.01AK.01@flex--ascull.bounces.google.com Received: by mail-wr1-x44a.google.com with SMTP id p8-20020a5d4588000000b0021033f1f79aso354028wrq.5 for ; Mon, 30 May 2022 03:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=2pVQIeb02EI9pAxgw2twlWAuLU3WXgZrZUlWOl+s3Aw=; b=OwqxfuHRA1lBLwMmQkd28rB7ZNq47z+gx2VZ8YYNyTHFMWbh511onflRWIzdQ+bock o4r4XYwiG73gnkZ6b48Tee1jeh1vI0fB4RrxZUoWewiEPhunK/0Fw3MK/32hCvGbWwNC U1k6davUBTOkbkTkpWrq/tUb4F6Y9d5VSlpdpWdqQLl9LRJhh45Wf79zxfqwhrRk5SUV joBFhhpCJibuB36aa7oX0MDXFiWGohkZy9CmSUYg0b123nKstb8e0NQLg4eMY16j15oC veB5UsKa/vUnMY8z1iOseu+JGEqgYfwh8KT8kM62qVjZM+SxG9s+0jSuUibOiB33CIhQ lpVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2pVQIeb02EI9pAxgw2twlWAuLU3WXgZrZUlWOl+s3Aw=; b=fxD6ECLbaQvoUJSOK/0YTCVtBrgbqG9tC3QhcbJa5gyQ9sPgVEOyJpcadhjz1dRTww 2Z+/+G0r2LFIsPDa/ayfPUKlxfY0bnJ6onL6utriZk3N+45xcO0REPhqLQvlaVxjryTx 0al5ykXM9UiRa2lU45t/v87WGeMtk9QPj0y0yNtSbHhJrJlhVJNsCNXt6PxfaJs7x5Tq p2ow4SMbCrQ7Fc3Dyu3RMNIbmkXFeQe0UCR2ty4x16cAKXdexqJ2Aga4eznywbKCFCOh ljxZA0qNscZwrABGRJwDqI06yKlrNK1K9tlCUaNRn7PTY+X9mSVkukxuqWrr7bPSBTMj yx9w== X-Gm-Message-State: AOAM532vjgH4NLfwVPkcwI7ej9iRHQiK5UkuzkXi/K0ptMjy/af1l4SM d9RAmyDH35dlUC5ZaMnh2U2grQPFIMjiECUfjOQD3NqyTdBKvRVqVTni0feRM23vYXCb2Ad6O58 22h4DirYXXPuGATgvZqMPGQejTpiQrlVjnjuQyiAwmuf+zVWKnfBNrwor3zc= X-Google-Smtp-Source: ABdhPJz7BfsQVUk//yNF/HmK27VadZPCuBALm2yZDpTLln13cIW1nVFYqHEGnt6UzUWeHtiH9H/kd8p3vrE= X-Received: from ascull.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:1510]) (user=ascull job=sendgmr) by 2002:a05:600c:22c4:b0:397:8436:be68 with SMTP id 4-20020a05600c22c400b003978436be68mr16802430wmg.102.1653904828341; Mon, 30 May 2022 03:00:28 -0700 (PDT) Date: Mon, 30 May 2022 10:00:01 +0000 In-Reply-To: <20220530100013.3753780-1-ascull@google.com> Message-Id: <20220530100013.3753780-2-ascull@google.com> Mime-Version: 1.0 References: <20220530100013.3753780-1-ascull@google.com> X-Mailer: git-send-email 2.36.1.124.g0e6072fb45-goog Subject: [PATCH v3 01/13] serial: sandbox: Fix buffer underflow in puts From: Andrew Scull To: u-boot@lists.denx.de Cc: sjg@chromium.org, trini@konsulko.com, xypron.glpk@gmx.de, jonbottarini@google.com, seanga2@gmail.com, Andrew Scull , Sean Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Fix the buffer underflow that would occur if puts is called with length of zero. Fixes: efa51f2bd64 ("serial: sandbox: Implement puts") Cc: Sean Anderson Cc: Simon Glass --- drivers/serial/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c index e726e19c46..13b54921c4 100644 --- a/drivers/serial/sandbox.c +++ b/drivers/serial/sandbox.c @@ -114,7 +114,7 @@ static ssize_t sandbox_serial_puts(struct udevice *dev, const char *s, struct sandbox_serial_priv *priv = dev_get_priv(dev); ssize_t ret; - if (s[len - 1] == '\n') + if (len && s[len - 1] == '\n') priv->start_of_line = true; if (sandbox_serial_enabled) { -- 2.36.1.124.g0e6072fb45-goog