Re: [PULL] u-boot-riscv/master

Green Wan
2021-05-27T08:57:40Z

Hi Tom,

Thanks for the comments.

Not sure whether it catches different concerns, I plan to remove fdt_high
and initrd_high since the bootm_* settings should be sufficient to
calculate the values related to fdt_high and initrd_high. And I checked the
bootm_* settings as below, the system can boot without fdt_high and
initrd_high.

- bootm_low is set to CONFIG_SYS_SDRAM_BASE
- bootm_size is set to gd->ram_size (which comes from DT)
- bootm_mapsize is now equal to bootm_size
- boot log without fdt_high and initrd_high
"## Flattened Device Tree blob at 88000000
Booting using the fdt blob at 0x88000000
Loading Device Tree to 00000000ffffa000, end 00000000fffff64d ... OK"

Hi Leo/Rick,

Should I create v12 for fu740 series patchset based on u-boot-riscv.git ?
or revert [PATCH v11 7/8] plus a patch? Thanks a lot!

Regards,
Green

On Wed, May 26, 2021 at 11:24 PM Tom Rini <trini@konsulko.com> wrote:

> On Wed, May 26, 2021 at 04:12:50PM +0800, Leo Liang wrote:
>
> > Hi Tom,
> >
> > The following changes since commit
> eb53b943be2949ca111140a8e05532cd74cda058:
> >
> > Merge https://source.denx.de/u-boot/custodians/u-boot-sh (2021-05-23
> 10:15:15 -0400)
> >
> > are available in the Git repository at:
> >
> > git@source.denx.de:u-boot/custodians/u-boot-riscv.git
> >
> > for you to fetch changes up to 9358576a281ab5e3b7348685bbd5f713833a5048:
> >
> > drivers: pci: pcie_dw_common: fix Werror compilation error (2021-05-24
> 23:54:54 +0800)
> >
> > Gitlab CI result shows no issue:
> https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/7620
> >
>
> NAK.
> ERROR: fdt or initrd relocation disabled at boot time
> #993: FILE: include/configs/sifive-unmatched.h:65:
> + "fdt_high=0xffffffffffffffff\0" \
>
> ERROR: fdt or initrd relocation disabled at boot time
> #994: FILE: include/configs/sifive-unmatched.h:66:
> + "initrd_high=0xffffffffffffffff\0" \
>
> You can, but shouldn't disable initrd relocation. You cannot disable
> device tree relocation as that leads to too many issues due to
> misalignment later. Make use of bootm_size or similar to make sure
> everything is within an appropriate area of memory. Thanks.
>
> --
> Tom
>