From: Tom Rini <trini@konsulko.com>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, u-boot@lists.denx.de
Subject: Re: [PATCH v1 3/9] board: hpe: gxp: add HPE GXP soc support
Date: Wed, 1 Jun 2022 10:24:20 -0400 [thread overview]
Message-ID: <20220601142420.GH25375@bill-the-cat> (raw)
In-Reply-To: <20220526185548.14104-3-nick.hawkins@hpe.com>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
On Thu, May 26, 2022 at 01:55:42PM -0500, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> Add basic support for the HPE GXP SoC. Reset the EHCI controller at
> boot.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
> board/hpe/gxp/Kconfig | 47 +++++++++++++++++++++++++++++++++++++++
> board/hpe/gxp/Makefile | 1 +
> board/hpe/gxp/gxp_board.c | 33 +++++++++++++++++++++++++++
> 3 files changed, 81 insertions(+)
> create mode 100644 board/hpe/gxp/Kconfig
> create mode 100644 board/hpe/gxp/Makefile
> create mode 100644 board/hpe/gxp/gxp_board.c
[snip]
> +config GXP_ECC
> + default n
> + bool "Enable memory ECC protected"
"n" is the normal default, so you don't need to add it here.
> + help
> + Use half of memory to enable ECC protected
The normal indentation is "<tab><space><space>".
> diff --git a/board/hpe/gxp/gxp_board.c b/board/hpe/gxp/gxp_board.c
> new file mode 100644
> index 0000000000..7fc1bf2fd6
> --- /dev/null
> +++ b/board/hpe/gxp/gxp_board.c
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * GXP timer driver
> + *
> + * (C) Copyright 2022 Hewlett Packard Enterprise Development LP.
> + * Author: Nick Hawkins <nick.hawkins@hpe.com>
> + * Author: Jean-Marie Verdun <verdun@hpe.com>
> + */
> +
> +#include <asm/io.h>
> +#include <common.h>
Here and elsewhere, <common.h> really just grabs a few other header
files. Don't use it, and include what you need directly instead.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-06-01 14:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 18:55 [PATCH v1 1/9] ARM: hpe: gxp: add core support nick.hawkins
2022-05-26 18:55 ` [PATCH v1 2/9] timer: gxp: Add HPE GXP timer support nick.hawkins
2022-05-26 18:55 ` [PATCH v1 3/9] board: hpe: gxp: add HPE GXP soc support nick.hawkins
2022-06-01 14:24 ` Tom Rini [this message]
2022-05-26 18:55 ` [PATCH v1 4/9] dt-bindings: arm: hpe: add GXP Support nick.hawkins
2022-05-26 18:55 ` [PATCH v1 5/9] dt-bindings: timer: Add hpe gxp timer nick.hawkins
2022-05-26 18:55 ` [PATCH v1 6/9] ARM: dts: Add device tree files for hpe gxp soc nick.hawkins
2022-06-01 14:24 ` Tom Rini
2022-06-01 14:50 ` Hawkins, Nick
2022-06-01 15:28 ` Tom Rini
2022-06-02 20:56 ` Hawkins, Nick
2022-06-02 20:56 ` Hawkins, Nick
2022-06-03 13:23 ` Tom Rini
2022-06-03 15:35 ` Hawkins, Nick
2022-06-03 16:24 ` Tom Rini
2022-05-26 18:55 ` [PATCH v1 7/9] configs: gxp: add core support nick.hawkins
2022-06-01 14:24 ` Tom Rini
2022-06-02 14:46 ` Hawkins, Nick
2022-06-02 14:50 ` Tom Rini
2022-05-26 18:55 ` [PATCH v1 8/9] configs: gxp: add gxp_defconfig nick.hawkins
2022-05-26 18:55 ` [PATCH v1 9/9] MAINTAINERS: Introduce HPE GXP Architecture nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601142420.GH25375@bill-the-cat \
--to=trini@konsulko.com \
--cc=nick.hawkins@hpe.com \
--cc=u-boot@lists.denx.de \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox