From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C672CCA468 for ; Wed, 1 Jun 2022 14:24:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E011842C6; Wed, 1 Jun 2022 16:24:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="o90lJ7W3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DDAD7842AF; Wed, 1 Jun 2022 16:24:32 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 426DD842A6 for ; Wed, 1 Jun 2022 16:24:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id 135so1414183qkm.4 for ; Wed, 01 Jun 2022 07:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HgGzV5ni2b5lANWlU+/U9gBzaHabkaSMvRqy/951+Zs=; b=o90lJ7W3tIVsVeBH48ad9iFBUPx4h9PF28LmBEEJKSu/KR8sV+pN2YDQoKnvcmJBBW W8NrKzym0pWb7zHVGpxX7k+dkbfXskftlazcKk9oBfnhz9fhow1yNrMhH4/xms4f/E9P oBgXum0SyUx8kJSS/NT5Vo8xcox2eoYgJuKz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HgGzV5ni2b5lANWlU+/U9gBzaHabkaSMvRqy/951+Zs=; b=eMvfXkIaGqIg6jUMsxHp3grXO2/bPMA3PP0QQlUq86VgZ22uJdwv5UAhMRZLN7Drrc VNof/j2Es8I9BnvO3HxjpMFtiPPl20pVGsO4PVX++ivPVRUspm9qQWsTFfT4xZjHHcB2 xN5pZ0nHULnOqyPa2yBMjVbd1FOcZX3wtSHmGhVkr7dc9EgYfzE0T9TlK8LqId0pR0IU zEoWkmVqEXscl2jL9FwRckOgRtrebP84YlJyVbPE8+1g2pRqX4P3BPB7cluIDpEa7XSq gAe8bnRFO/sNL3d4zKzr/Tc4U1vvdAPyeBOXPw1LPMLsZejeR1D3iRUUhyyH77eBTn5W d+Xw== X-Gm-Message-State: AOAM531UWyYdS7C+pp1aXiwmR2Gns44z84IeULgBRCwopF5NXcGPl+tR 7ZfrmRIcs3WekaA2hvh5XdODq+HunbcjPg== X-Google-Smtp-Source: ABdhPJymm87nBKVzkiRjwnd0rly1H7Ussx9dL+fdr1oQuXKhkE218xv2BUA4p0LiOsRZLKaVOEwNAQ== X-Received: by 2002:a05:620a:16b1:b0:6a6:9a7:21d2 with SMTP id s17-20020a05620a16b100b006a609a721d2mr202963qkj.343.1654093468053; Wed, 01 Jun 2022 07:24:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-25fd-0000-0000-0000-1003.res6.spectrum.com. [2603:6081:7b00:25fd::1003]) by smtp.gmail.com with ESMTPSA id x22-20020ac84a16000000b00304c5a2e430sm1132003qtq.77.2022.06.01.07.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 07:24:27 -0700 (PDT) Date: Wed, 1 Jun 2022 10:24:25 -0400 From: Tom Rini To: nick.hawkins@hpe.com Cc: verdun@hpe.com, u-boot@lists.denx.de Subject: Re: [PATCH v1 7/9] configs: gxp: add core support Message-ID: <20220601142425.GI25375@bill-the-cat> References: <20220526185548.14104-1-nick.hawkins@hpe.com> <20220526185548.14104-7-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hW3Q5Oh0pcvvyJMS" Content-Disposition: inline In-Reply-To: <20220526185548.14104-7-nick.hawkins@hpe.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --hW3Q5Oh0pcvvyJMS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 26, 2022 at 01:55:46PM -0500, nick.hawkins@hpe.com wrote: > From: Nick Hawkins >=20 > Add the include file for the gxp soc. >=20 > Signed-off-by: Nick Hawkins [snip] > +#ifdef CONFIG_TARGET_GXP > +#ifdef CONFIG_GXP_ECC > + #define CONFIG_SYS_SDRAM_SIZE 0x0f800000 > +#else > + #define CONFIG_SYS_SDRAM_SIZE 0x1f000000 > +#endif > + > +#ifdef CONFIG_GXP_VROM_64MB > + #undef CONFIG_SYS_SDRAM_SIZE > + #ifdef CONFIG_GXP_ECC > + #define CONFIG_SYS_SDRAM_SIZE 0x0c000000 > + #else > + #define CONFIG_SYS_SDRAM_SIZE 0x18000000 > + #endif > +#endif Can we figure any of that out dynamically instead? Since CONFIG_SYS_SDRAM_SIZE is only used (for ARM) in board code, I'd rather see this handled in there, with SZ_xxx and not use CONFIG_SYS_SDRAM_SIZE at all. --=20 Tom --hW3Q5Oh0pcvvyJMS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKXdpkACgkQFHw5/5Y0 tyxk/Av9GbeTwoBrzLbizROQ2baikbuPtApBp/ektqUMpV0mZuGs+0wija3lIpqL JjXOIFSQQvzTdy8ZiPpdl+fVIPzvzcJ3DX+P1vRqLQqH4JK+vUUj3i2P7jrpHAWI zaFkxdaN8QpD87KhPUkaKDthgbYVtOFFm1+KWtlSHtkDWDqBP7F1TZo3PoE8f+YT jN6y1dzSx1iS68kNlG9rFDZViziEfANY+27SABATluEy6qhKUvesje/1lpaz0hhS Fh5oLJiEaSMcB6tuoNtNalo1/aemlrbqSOgTst7y2Mg5yawJgCODSsBsNFCk7j9T ZO+LG2ClCbszNMq+bFTo4UyBRoA5i7NlDbuNprDEmM59oumTv10SsuWMsrTIf3a4 CmeLU1FedPgwGbJKeOxT9R+Ke7ZSMv6pQU0bfufz0Hen5v/e1EAmA/xi35owyhcw nalg1XZc+FwcE7GVjh7WF7PpjCX1dHBubTdXH/FGZMo0OwMtc+baJ36Rn3cksO0v +JVeFly4 =zmme -----END PGP SIGNATURE----- --hW3Q5Oh0pcvvyJMS--