From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: u-boot@lists.denx.de
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com, lukma@denx.de, seanga2@gmail.com
Subject: Re: [PATCH 1/3] Reserve some RAM at 0 for bl31_0x00000000.bin for Radxa Rock Pi 4.
Date: Thu, 2 Jun 2022 13:05:51 +0200 [thread overview]
Message-ID: <20220602110550.GC1727@begut> (raw)
In-Reply-To: <20220602110200.GB1727@begut>
When trying to boot from MMC in a Rock Pi 4 where I shorted
SPI clk to GND to have bootrom load tpl+spl from MMC, SPL
hanged after the message "Trying to boot from MMC1".
With this patch it continued booting, printed two notices
from ATF with BL31 version and date, and loaded U-Boot proper.
I'm not sure if there's something special with the ATF I built,
or what would be a reasonable standard for the size of BL31@0
but in my u-boot.its I find
atf_1 {
description = "ARM Trusted Firmware";
data = /incbin/("bl31_0x00000000.bin");
type = "firmware";
arch = "arm64";
os = "arm-trusted-firmware";
compression = "none";
load = <0x00000000>;
entry = <0x00001000>;
};
and bl31_0x00000000.bin size is 82008 bytes.
0x15000 is 86016 which gives some room for variation and
seems good aligned enough. I don't want to make u-boot too big.
Most other boards which define CONFIG_ROCKCHIP_SPL_RESERVE_IRAM
put it at 0x4000 but in my tests this wasn't enough.
Signed-off-by: Xavier Drudis Ferran <xdrudis@tinet.cat>
---
configs/rock-pi-4-rk3399_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig
index 8861f13878..510028b095 100644
--- a/configs/rock-pi-4-rk3399_defconfig
+++ b/configs/rock-pi-4-rk3399_defconfig
@@ -7,6 +7,7 @@ CONFIG_NR_DRAM_BANKS=1
CONFIG_ENV_OFFSET=0x3F8000
CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-pi-4b"
CONFIG_ROCKCHIP_RK3399=y
+CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x15000
CONFIG_TARGET_EVB_RK3399=y
CONFIG_DEBUG_UART_BASE=0xFF1A0000
CONFIG_DEBUG_UART_CLOCK=24000000
--
2.20.1
next prev parent reply other threads:[~2022-06-02 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:02 [PATCH 0/3] arm: rockchip: rk3399: rock-pi-4: power domain driver to boot from MMCSD Xavier Drudis Ferran
2022-06-02 11:05 ` Xavier Drudis Ferran [this message]
2022-06-02 11:06 ` [PATCH 2/3] Add a couple of missing clocks for MMCSD Xavier Drudis Ferran
2022-06-02 11:08 ` [PATCH 3/3] arm: rockchip: rk3399: Power domain driver for rockchip Xavier Drudis Ferran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602110550.GC1727@begut \
--to=xdrudis@tinet.cat \
--cc=kever.yang@rock-chips.com \
--cc=lukma@denx.de \
--cc=philipp.tomsich@vrull.eu \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox