From: "AKASHI, Takahiro" <takahiro.akashi@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
Tom Rini <trini@konsulko.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Simon Glass <sjg@chromium.org>,
ilias.apalodimas@linaro.org, U-Boot-Denx <u-boot@lists.denx.de>,
Heiko Thiery <heiko.thiery@gmail.com>
Subject: Re: [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice
Date: Tue, 14 Jun 2022 08:39:30 +0900 [thread overview]
Message-ID: <20220613233930.GA35072@laputa> (raw)
In-Reply-To: <CAOMZO5CG_XTwGYm10UOTLbo8G7PhZ8A7piFxarKDb2s9tRggaA@mail.gmail.com>
On Mon, Jun 13, 2022 at 07:48:01PM -0300, Fabio Estevam wrote:
> Hi Mark,
>
> On Mon, Jun 13, 2022 at 7:21 PM Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> > This looks like the reply the terminal sends in response to the "Query
> > cursor position" command that is sent in
> > lib/efi_loader/efi_console.c:query_console_serial().
> >
> > It might be worth trying to increase the timeout in term_get_char().
>
> I did as you suggested and increased the timeout from 100ms to 1000ms.
>
> After that, I no longer see the problem, thanks!
So I hope that my patch has broken nothing.
-Takahiro Akashi
> Would this be an acceptable fix?
next prev parent reply other threads:[~2022-06-13 23:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 1:05 [PATCH v5 00/12] efi_loader: more tightly integrate UEFI disks to driver model AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 01/12] dm: tag: change ENOSPC to ENOMEM AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 02/12] dm: tag: add some document AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 03/12] test: dm: add tests for tag support AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 04/12] dm: disk: add UCLASS_PARTITION AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 05/12] dm: blk: add a device-probe hook for scanning disk partitions AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 06/12] efi_loader: split efi_init_obj_list() into two stages AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice AKASHI Takahiro
2022-04-30 18:44 ` Johan Jonker
2022-05-18 9:23 ` Neil Armstrong
2022-05-19 5:04 ` AKASHI Takahiro
2022-06-01 0:25 ` AKASHI Takahiro
2022-08-24 9:00 ` Vyacheslav
2022-08-24 9:29 ` Vyacheslav
2022-06-13 19:54 ` Fabio Estevam
2022-06-13 20:10 ` Tom Rini
2022-06-13 22:21 ` Mark Kettenis
2022-06-13 22:48 ` Fabio Estevam
2022-06-13 23:39 ` Heinrich Schuchardt
2022-06-13 23:54 ` Fabio Estevam
2022-06-14 3:59 ` Heiko Thiery
2022-06-13 23:39 ` AKASHI, Takahiro [this message]
2022-04-19 1:05 ` [PATCH v5 08/12] efi_loader: disk: not create BLK device for BLK(IF_TYPE_EFI_LOADER) devices AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 09/12] efi_loader: disk: a helper function to delete efi_disk objects AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 10/12] efi_loader: disk: not delete BLK device for BLK(IF_TYPE_EFI_LOADER) devices AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 11/12] dm: disk: add read/write interfaces with udevice AKASHI Takahiro
2022-04-19 1:05 ` [PATCH v5 12/12] efi_loader: disk: use udevice instead of blk_desc AKASHI Takahiro
2022-04-25 20:43 ` [PATCH v5 00/12] efi_loader: more tightly integrate UEFI disks to driver model Heinrich Schuchardt
2022-04-25 23:44 ` AKASHI Takahiro
2022-04-26 13:57 ` Heinrich Schuchardt
2022-04-26 14:44 ` AKASHI Takahiro
2022-04-26 17:02 ` Heinrich Schuchardt
2022-04-26 17:18 ` Mark Kettenis
2022-04-26 17:23 ` Tom Rini
2022-04-27 3:26 ` AKASHI Takahiro
2022-04-28 4:52 ` AKASHI Takahiro
2022-04-28 6:45 ` Heinrich Schuchardt
2022-04-28 9:09 ` Mark Kettenis
2022-04-28 9:42 ` Heinrich Schuchardt
2022-04-28 10:11 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613233930.GA35072@laputa \
--to=takahiro.akashi@linaro.org \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=mark.kettenis@xs4all.nl \
--cc=narmstrong@baylibre.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox