From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBCDEC43334 for ; Wed, 15 Jun 2022 03:01:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E96A9843AF; Wed, 15 Jun 2022 05:01:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="k5UHQbKV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94C0B843B4; Wed, 15 Jun 2022 05:01:26 +0200 (CEST) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 651CB8439A for ; Wed, 15 Jun 2022 05:01:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62f.google.com with SMTP id r1so9267707plo.10 for ; Tue, 14 Jun 2022 20:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=8MlbTNOPgVmJ8z1fMRGaya3T9EWhsrw7BHfs3mqHx0I=; b=k5UHQbKV2lazUSdFILceYdfUpmZ1R9+1shHj+mood8b9wvcmMi/x7sPW/GThd28hwn LzvebZXiaJklDWAa1tEvbn/uc+mEFLiZHQu6sH6JW4lPZnI7lPUa6l0gM4FL8jvNWE6v szj5G3YIWwRoYpCyJIianfgdaQTF+brJmuBWScpZgQVerSr9D1UoeKttzS4mTVeBbu3+ vfTQdyef/OvjXOfmWgjYS8WkrnVLzIDJW4Kcd8sUGEMnSjCeKlmBS1KXXEfTnm461EwN +EqB0A7d9CWHLTwptW/g8W5lubzkzozQ/C8rIsNj7zphFzIeaK/NY6UTM2asmiWCAAI5 VeGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=8MlbTNOPgVmJ8z1fMRGaya3T9EWhsrw7BHfs3mqHx0I=; b=G62DKQ9ltrVCF07Ttj8zS0SrJfj/Cm8hIq0HmrZBOK/bJ1186owhdx2cKUhuWIQxC5 J7UcKrFEiqyfF9J7YbuhkDQ80XKybeNnkfJJO0w54CDJF6TbjquJgbPKqRtqiI2Hmj2N wnMr0DH/EtfVbevn7NAHG/JfFMg3SzBUoKJ4mqrPR+AjcNMW6g2dJBIZIanW7Lny3HM3 ZcseAtZQ+FagNFKxcFcjgAtLhmeVLpsKaKaqQIZeLO6O9TqqZQAfGcCbK9obWr0JG2jX IihWvDpJpYuRHzn/yZL1u1oj3vP+N/jiyyQ29S6uOFpDTho50vM+U2qexk5G9DrbNE+5 lbOg== X-Gm-Message-State: AJIora+TJjeBbOXympUGmM6bIfxs0S1zqYKJZB7A/28+rE11wjKB5Xdu eqsPEADdFsNuHoenHLcunPR/gA== X-Google-Smtp-Source: AGRyM1uXiUsyPIHlU0HT72W4lKwigwuB0mZ52dOH9TV6yrJmTrk6OMAMqIYqhSc56SVZeLY5t2gDzw== X-Received: by 2002:a17:90b:4a12:b0:1e8:4a16:ae28 with SMTP id kk18-20020a17090b4a1200b001e84a16ae28mr7780289pjb.1.1655262081616; Tue, 14 Jun 2022 20:01:21 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:a4bc:d07a:731c:3758]) by smtp.gmail.com with ESMTPSA id h13-20020a056a00000d00b0051ba8b742e4sm8325394pfk.69.2022.06.14.20.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 20:01:21 -0700 (PDT) Date: Wed, 15 Jun 2022 12:01:17 +0900 From: Takahiro Akashi To: Masahisa Kojima Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Simon Glass , Francois Ozog , Mark Kettenis Subject: Re: [PATCH v7 0/9] enable menu-driven UEFI variable maintenance Message-ID: <20220615030117.GA58082@laputa> Mail-Followup-To: Takahiro Akashi , Masahisa Kojima , u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Simon Glass , Francois Ozog , Mark Kettenis References: <20220613093853.23865-1-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613093853.23865-1-masahisa.kojima@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, Jun 13, 2022 at 06:38:44PM +0900, Masahisa Kojima wrote: > This series add the menu-driven UEFI boot variable maintenance > and removable media support in bootmenu. > > Different from previous version, thie series adds a new U-Boot > command "efimenu" to invoke the UEFI boot-related variable > maintenance menu. Thanks. I'd like to give this command a more *specific* name rather than just "menu" :) For example, eficontrol or eficonfig. The followings are my comments mostly from user's perspective (or user-friendliness). So you may take them as improvements. * make menuconfig, "provide menu-driven uefi variables maintenance feature" Please add the command name, so "efimenu - ..." * the command can lead to a segmentation fault. I see it on sandbox. efi_init_obj_list() must always be called at the beginning. * If no boot option is defined yet, "Edit/Order/Delete" menu's simply return to the top menu. I expect some (error) message here. * This may happen even at "Add" if there is no block device. * Boot options without file paths (mostly for removable disks) appear in "Change Order" only if "bootmenu" is executed beforehand. This looks weird. * Some menu's have "Quit", others not. In some menu's, "Quit" means "quit without change" which is equivalent to "Esc". It looks a bit inconsistent. * Some menu's have "Save", others not. For instance, "Change Order" should have explicit "Save" so that user may cancel the change. * "Add" - The header line is "Edit Boot Option". -> Add Boot Option - Users may want to add an additional device path, especially for initrd. * "Edit" - The header line is "Select Boot Order". -> Select Boot Option - If "Description" is selected, I expect the current value is shown at editing screen. - If "File" is selected, I expect I can start with the last component (i.e. a file path). This might be arguable, though. - Users may want to have a short-form path. - Users may want to have a file path without a device media path. Now those variants for device path are acceptable in U-Boot implementation. * "Change Boot Order" - Users may want to remove a boot option (for a removable disk) which is automatically inserted by "bootmenu" from BootOrder. (The given boot option may still exist as a variable.) - As I said above, "Save" and "Quit" should be shown. * "Delete" - The header line is "Select Boot Order". -> Delete Boot Option -Takahiro Akashi > Note that menu-driven UEFI Secure Boot key management patch series > will follow. > > [Major Changes] > - rebased to v2022.07-rc4 > - there is detailed changelog in each commit > > Masahisa Kojima (9): > efi_loader: expose END device path node > efimenu: menu-driven addition of UEFI boot option > efimenu: add "Edit Boot Option" menu entry > menu: add KEY_PLUS and KEY_MINUS handling > efimenu: add "Change Boot Order" menu entry > efimenu: add "Delete Boot Option" menu entry > bootmenu: add removable media entries > doc:bootmenu: add description for UEFI boot support > doc:efimenu: add documentation for efimenu command > > cmd/Kconfig | 7 + > cmd/Makefile | 1 + > cmd/bootmenu.c | 99 +- > cmd/efimenu.c | 1824 ++++++++++++++++++++++++++++++ > common/menu.c | 6 + > doc/usage/cmd/bootmenu.rst | 74 ++ > doc/usage/cmd/efimenu.rst | 50 + > doc/usage/index.rst | 1 + > include/efi_loader.h | 63 ++ > include/efi_menu.h | 91 ++ > include/menu.h | 2 + > lib/efi_loader/efi_boottime.c | 52 +- > lib/efi_loader/efi_console.c | 78 ++ > lib/efi_loader/efi_device_path.c | 2 +- > lib/efi_loader/efi_disk.c | 11 + > lib/efi_loader/efi_file.c | 75 +- > 16 files changed, 2385 insertions(+), 51 deletions(-) > create mode 100644 cmd/efimenu.c > create mode 100644 doc/usage/cmd/efimenu.rst > create mode 100644 include/efi_menu.h > > -- > 2.17.1 >