From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B5A2C433EF for ; Wed, 15 Jun 2022 06:39:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 85CD8843D2; Wed, 15 Jun 2022 08:39:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="unYROXv7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BC583843D5; Wed, 15 Jun 2022 08:39:34 +0200 (CEST) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 22F95843D1 for ; Wed, 15 Jun 2022 08:39:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62d.google.com with SMTP id t2so9611682pld.4 for ; Tue, 14 Jun 2022 23:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=A1M3y5xICl06sYduzSrmybj13L5oYLB2nRmvEOGe8n4=; b=unYROXv7XMRRSe2nSfuRm0fLNApKz8cNR5ymm1S0ovXPSOsdpXlAtCX1quwmXP+dcv y/26LByhbcAjplhFMrytSLI+Hol/JIhPRdvQ3ouXrMDtreEbWrtBqduvjl0EyWPSMENr AzkATLLo1pWR7OHtWNRONy8QZKwZQju0+2sw6yygsSTIARAgbZyIMb5gqhkM80aUw+Zz jMOg4YhC4wdS12FQASnNwpcSu09O6DJzGedk8t7oUrl5E9ZkUbw/bp7uuta9zMU6p24L G63DRkdOkvSNPQZpJDlHz2neKBj9RsVDe7rJmW6aQ1TL/WxfnK0sC44joN8f01JT8NtC fTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=A1M3y5xICl06sYduzSrmybj13L5oYLB2nRmvEOGe8n4=; b=3NiC94opkbegDtY8MqbxnTH9t3QVhRZM3/K3CRhlBP3LUzzj/2TbqBa0F2xg3vbR4L zCEyBCCIpzWCmpK5gJMqaG3CQ7In3Qgzcp/WXcAvMdqHBolSCrlUXQd1qtfaN70wlaMA S4wDlhPQUCvmF/NborPPYlKJRamXidatvXQL9wHd9fFQgsZO1zreihOS2XyTD2DpKAs2 GDsrV5IsenDAx4QjT9LrrKHuQ0bz5gJiY5URXJjtiBz5mDGwVTBd8OnwDyMld5Qfmc+g bxa7qoZ74Uuu//e/bhmQjUh/WVE8pKjy52BsrXWYIZVQgcK655QTMKxkL5/VX2iw6/48 4YOA== X-Gm-Message-State: AJIora92zhhcaFbr02u0aY3vUPaXv7jOmct2ey0mYbpl1Iw0wiR2PWCD h1e1dknGSBpSoPCmsCuh5czzGA== X-Google-Smtp-Source: AGRyM1vs0v6NDbf3nK/bS3CZywS3+IPqfVFqjq+bZGXeWcoVKptrQ9o+0JsO1tTmWJXVTXKfNOXp7A== X-Received: by 2002:a17:902:efcc:b0:163:f35b:2a99 with SMTP id ja12-20020a170902efcc00b00163f35b2a99mr7959060plb.42.1655275169398; Tue, 14 Jun 2022 23:39:29 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:a4bc:d07a:731c:3758]) by smtp.gmail.com with ESMTPSA id u18-20020a170902e21200b0015e8d4eb2ddsm8351626plb.295.2022.06.14.23.39.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 23:39:29 -0700 (PDT) Date: Wed, 15 Jun 2022 15:39:23 +0900 From: Takahiro Akashi To: Heinrich Schuchardt Cc: Sughosh Ganu , Ilias Apalodimas , Patrick Delaunay , Patrice Chotard , Simon Glass , Bin Meng , Tom Rini , Etienne Carriere , Michal Simek , Jassi Brar , u-boot@lists.denx.de Subject: Re: [PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification Message-ID: <20220615063923.GA72176@laputa> Mail-Followup-To: Takahiro Akashi , Heinrich Schuchardt , Sughosh Ganu , Ilias Apalodimas , Patrick Delaunay , Patrice Chotard , Simon Glass , Bin Meng , Tom Rini , Etienne Carriere , Michal Simek , Jassi Brar , u-boot@lists.denx.de References: <20220609123010.1017463-1-sughosh.ganu@linaro.org> <20220609123010.1017463-9-sughosh.ganu@linaro.org> <4e77a616-2b32-17da-6533-f75777329830@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e77a616-2b32-17da-6533-f75777329830@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Jun 15, 2022 at 08:34:18AM +0200, Heinrich Schuchardt wrote: > On 6/9/22 14:29, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > > carry out certain checks at the time of platform boot. The Update > > Agent is the component which is responsible for updating the firmware > > components and maintaining and keeping the metadata in sync. > > > > The spec requires that the Update Agent perform the following checks > > at the time of boot > > * Sanity check of both the metadata copies maintained by the platform. > > * Get the boot index passed to U-Boot by the prior stage bootloader > > and use this value for metadata bookkeeping. > > * Check if the system is booting in Trial State. If the system boots > > in the Trial State for more than a specified number of boot counts, > > change the Active Bank to be booting the platform from. > > > > Add these checks in the board initialisation sequence, invoked after > > relocation. > > > > Signed-off-by: Sughosh Ganu > > --- > > common/board_r.c | 5 ++ > > include/fwu.h | 3 + > > lib/fwu_updates/fwu.c | 170 ++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 178 insertions(+) > > create mode 100644 lib/fwu_updates/fwu.c > > > > diff --git a/common/board_r.c b/common/board_r.c > > index 6f4aca2077..33a600715d 100644 > > --- a/common/board_r.c > > +++ b/common/board_r.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -797,6 +798,10 @@ static init_fnc_t init_sequence_r[] = { > > #if defined(CONFIG_PRAM) > > initr_mem, > > #endif > > + > > +#ifdef CONFIG_FWU_MULTI_BANK_UPDATE > > + fwu_boottime_checks, > > +#endif > > run_main_loop, > > }; > > > > diff --git a/include/fwu.h b/include/fwu.h > > index 41774ff9e2..8fbd91b463 100644 > > --- a/include/fwu.h > > +++ b/include/fwu.h > > @@ -33,6 +33,9 @@ struct fwu_mdata_ops { > > EFI_GUID(0x8a7a84a0, 0x8387, 0x40f6, 0xab, 0x41, \ > > 0xa8, 0xb9, 0xa5, 0xa6, 0x0d, 0x23) > > > > +int fwu_boottime_checks(void); > > +u8 fwu_update_checks_pass(void); > > + > > int fwu_get_mdata(struct fwu_mdata **mdata); > > int fwu_update_mdata(struct fwu_mdata *mdata); > > int fwu_get_active_index(u32 *active_idx); > > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c > > new file mode 100644 > > index 0000000000..af884439fb > > --- /dev/null > > +++ b/lib/fwu_updates/fwu.c > > @@ -0,0 +1,170 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (c) 2022, Linaro Limited > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > + > > +static u8 trial_state; > > +static u8 boottime_check; > > + > > +static int fwu_trial_state_check(void) > > +{ > > + int ret, i; > > + efi_status_t status; > > + efi_uintn_t var_size; > > + u16 trial_state_ctr; > > + u32 nimages, active_bank, var_attributes, active_idx; > > + struct fwu_mdata *mdata = NULL; > > + struct fwu_image_entry *img_entry; > > + struct fwu_image_bank_info *img_bank_info; > > + > > + ret = fwu_get_mdata(&mdata); > > + if (ret) > > + return ret; > > + > > + ret = 0; > > + nimages = CONFIG_FWU_NUM_IMAGES_PER_BANK; > > + active_bank = mdata->active_index; > > + img_entry = &mdata->img_entry[0]; > > + for (i = 0; i < nimages; i++) { > > + img_bank_info = &img_entry[i].img_bank_info[active_bank]; > > + if (!img_bank_info->accepted) { > > + trial_state = 1; > > + break; > > + } > > + } > > + > > + if (trial_state) { > > + var_size = (efi_uintn_t)sizeof(trial_state_ctr); > > + log_info("System booting in Trial State\n"); > > + var_attributes = EFI_VARIABLE_NON_VOLATILE | > > + EFI_VARIABLE_BOOTSERVICE_ACCESS; > > + status = efi_get_variable_int(L"TrialStateCtr", > > + &efi_global_variable_guid, > > + &var_attributes, > > + &var_size, &trial_state_ctr, > > + NULL); > > + if (status != EFI_SUCCESS) { > > + log_err("Unable to read TrialStateCtr variable\n"); > > + ret = -1; > > + goto out; > > + } > > + > > + ++trial_state_ctr; > > + if (trial_state_ctr > CONFIG_FWU_TRIAL_STATE_CNT) { > > + log_info("Trial State count exceeded. Revert back to previous_active_index\n"); > > + active_idx = mdata->active_index; > > + ret = fwu_revert_boot_index(); > > + if (ret) { > > + log_err("Unable to revert active_index\n"); > > + goto out; > > + } > > + > > + trial_state_ctr = 0; > > + status = efi_set_variable_int(L"TrialStateCtr", > > + &efi_global_variable_guid, > > + var_attributes, > > + 0, > > + &trial_state_ctr, false); > > + if (status != EFI_SUCCESS) { > > + log_err("Unable to clear TrialStateCtr variable\n"); > > + ret = -1; > > + goto out; > > + } > > + } else { > > + status = efi_set_variable_int(L"TrialStateCtr", > > + &efi_global_variable_guid, > > + var_attributes, > > + var_size, > > + &trial_state_ctr, false); > > + if (status != EFI_SUCCESS) { > > + log_err("Unable to increment TrialStateCtr variable\n"); > > + ret = -1; > > + goto out; > > + } > > + } > > + } else { > > + trial_state_ctr = 0; > > + status = efi_set_variable_int(L"TrialStateCtr", > > + &efi_global_variable_guid, > > + 0, > > + 0, &trial_state_ctr, > > + NULL); > > + } > > + > > +out: > > + free(mdata); > > + return ret; > > +} > > + > > +u8 fwu_update_checks_pass(void) > > +{ > > + return !trial_state && boottime_check; > > +} > > + > > +int fwu_boottime_checks(void) > > +{ > > + int ret; > > + struct udevice *dev; > > + u32 boot_idx, active_idx; > > + > > + if (uclass_get_device(UCLASS_FWU_MDATA, 0, &dev) || !dev) { > > + log_err("FWU Metadata device not found\n"); > > + return 0; > > + } > > + > > + ret = fwu_mdata_check(); > > + if (ret) { > > + return 0; > > + } > > + > > + /* > > + * Get the Boot Index, i.e. the bank from > > + * which the platform has booted. This value > > + * gets passed from the ealier stage bootloader > > + * which booted u-boot, e.g. tf-a. If the > > + * boot index is not the same as the > > + * active_index read from the FWU metadata, > > + * update the active_index. > > + */ > > + fwu_plat_get_bootidx(&boot_idx); > > + if (boot_idx >= CONFIG_FWU_NUM_BANKS) { > > + log_err("Received incorrect value of boot_index\n"); > > + return 0; > > + } > > + > > + ret = fwu_get_active_index(&active_idx); > > + if (ret) { > > + log_err("Unable to read active_index\n"); > > + return 0; > > + } > > + > > + if (boot_idx != active_idx) { > > + log_info("Boot idx %u is not matching active idx %u, changing active_idx\n", > > + boot_idx, active_idx); > > + ret = fwu_update_active_index(boot_idx); > > + if (!ret) > > + boottime_check = 1; > > + > > + return 0; > > + } > > + > > + if (efi_init_obj_list() != EFI_SUCCESS) > > efi_init_obj_list() slows down the boot process. Why do want to invoke > it if no EFI binary is launched? Because fwu_boottime_checks() must access UEFI variables. -Takahiro Akashi > See also Takahiro's hint in > https://lore.kernel.org/all/20220615061616.GD58082@laputa/ > > Best regards > > Heinrich > > > + return 0; > > + > > + ret = fwu_trial_state_check(); > > + if (!ret) > > + boottime_check = 1; > > + > > + return 0; > > +} >