[PATCH] spi: nxp_fspi: Fix clock imbalance

[PATCH] spi: nxp_fspi: Fix clock imbalance

[Marek Vasut]

The nxp_fspi_default_setup() is only ever called from nxp_fspi_probe(),
where the IP clock are initially disabled. Drop the second disabling of
clock to prevent clock enable/disable imbalance reported by clock core:

"
clk qspi_root_clk already disabled
"

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 drivers/spi/nxp_fspi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c
index 607c953987b..579d6bac9b1 100644
--- a/drivers/spi/nxp_fspi.c
+++ b/drivers/spi/nxp_fspi.c
@@ -866,9 +866,6 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)
 	u32 reg;
 
 #if CONFIG_IS_ENABLED(CLK)
-	/* disable and unprepare clock to avoid glitch pass to controller */
-	nxp_fspi_clk_disable_unprep(f);
-
 	/* the default frequency, we will change it later if necessary. */
 	ret = clk_set_rate(&f->clk, 20000000);
 	if (ret < 0)
-- 
2.35.1

Re: [PATCH] spi: nxp_fspi: Fix clock imbalance

[Peng Fan (OSS)]

在 2022/6/13 20:35, Marek Vasut 写道:
> The nxp_fspi_default_setup() is only ever called from nxp_fspi_probe(),
> where the IP clock are initially disabled. Drop the second disabling of
> clock to prevent clock enable/disable imbalance reported by clock core:
>
> "
> clk qspi_root_clk already disabled
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>   drivers/spi/nxp_fspi.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c
> index 607c953987b..579d6bac9b1 100644
> --- a/drivers/spi/nxp_fspi.c
> +++ b/drivers/spi/nxp_fspi.c
> @@ -866,9 +866,6 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)
>   	u32 reg;
>   
>   #if CONFIG_IS_ENABLED(CLK)
> -	/* disable and unprepare clock to avoid glitch pass to controller */
> -	nxp_fspi_clk_disable_unprep(f);
> -
>   	/* the default frequency, we will change it later if necessary. */
>   	ret = clk_set_rate(&f->clk, 20000000);
>   	if (ret < 0)

[PATCH] spi: nxp_fspi: Fix clock imbalance

[sbabic]

> The nxp_fspi_default_setup() is only ever called from nxp_fspi_probe(),
> where the IP clock are initially disabled. Drop the second disabling of
> clock to prevent clock enable/disable imbalance reported by clock core:
> "
> clk qspi_root_clk already disabled
> "
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================