Re: [RFC PATCH v4 25/28] cli: hush_2021: Add upstream commits up to 6th February 2022.

Francis Laniel
2022-08-12T20:56:36Z

Hi.

Le lundi 20 juin 2022, 21:11:00 CEST Tom Rini a écrit :
> On Fri, Jun 17, 2022 at 12:31:55AM +0200, Francis Laniel wrote:
> > This commit adds the following hush busybox upstream commits:
> > 21afddefd258 ("hush: fix "error: invalid preprocessing directive ##"")
> > e53c7dbafc78 ("hush: fix set -n to act immediately, not just after
> > run_list() ")
> > 574b9c446da1 ("hush: fix var_LINENO3.tests failure")
> > 49bcf9f40cff ("hush: speed up ${x//\*/|} too")
> > 53b2fdcdba4c ("*: add NOINLINEs where code noticeably shrinks")
> > 7c3e96d4b3d4 ("shell: use more compact SHELL_ASH / HUSH config defines. no
> > code changes") 62f1eed1e191 ("hush: in a comment, document what -i might
> > be doing") aaf3d5ba74c5 ("shell: tweak --help")
> > db5546ca1018 ("libbb: code shrink: introduce and use [_]exit_SUCCESS()")
> > 931c55f9e2b4 ("libbb: invert the meaning of SETUP_ENV_NO_CHDIR ->
> > SETUP_ENV_CHDIR") 12566e7f9b5e ("ash,hush: fix handling of SIGINT while
> > waiting for interactive input") 987be932ed3c ("*: slap on a few ALIGN_PTR
> > where appropriate")
> >
> > Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
>
> Oh good, this was added to the series. How much effort did it take you
> to do this? Do you think it would be sustainable to keep doing
> something like this once every U-Boot full release cycle, like say when
> -next opens up or just after release or similar?

Sorry for my late reply.

I was not so complicated to add these patches as they did not really touch
part we have in common.
I think it took me sometimes because I wanted to understand everything to
avoid breaking things.

I would rather advice doing this more often, something like once a month as
the less patches we will need to merge the easier it is.