Re: [PATCH v5 14/23] dt/bindings: firmware: Add FWU metadata on MTD devices binding

Etienne Carriere
2022-06-21T10:57:32Z

On Thu, 9 Jun 2022 at 14:31, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> From: Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
> Add a devicetree-binding YAML file for the FWU metadata on MTD
> devices without GPT.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> ---
> .../firmware/uboot,fwu-mdata-mtd.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml
>
> diff --git a/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml b/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml
> new file mode 100644
> index 0000000000..4f5404f999
> --- /dev/null
> +++ b/doc/device-tree-bindings/firmware/uboot,fwu-mdata-mtd.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/u-boot,fwu-mdata-sf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FWU metadata on MTD device without GPT
> +
> +maintainers:
> + - Masami Hiramatsu <masami.hiramatsu@linaro.org>
> +
> +properties:
> + compatible:
> + items:
> + - const: u-boot,fwu-mdata-mtd
> +
> + fwu-mdata-store:
> + maxItems: 1
> + description: Phandle of the MTD device which contains the FWU medatata.
> +
> + mdata-offsets:
> + minItems: 2
> + description: Offsets of the primary and secondary FWU metadata in the NOR flash.
> +
> +required:
> + - compatible
> + - fwu-mdata-store
> + - mdata-offsets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + fwu-mdata {
> + compatible = "u-boot,fwu-mdata-mtd";
> + fwu-mdata-store = <&spi-flash>;
> + mdata-offsets = <0x500000 0x530000>;

Is a single 32bit value sufficient to define a block offset in an MTD
device? I was thinking of NAND with a density > 4GByte.

> + };

> --
> 2.25.1
>