From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 13/17] socrates: Rework CONFIG_PCI_CLK_FREQ
Date: Mon, 20 Jun 2022 08:07:54 -0400 [thread overview]
Message-ID: <20220620120758.765049-13-trini@konsulko.com> (raw)
In-Reply-To: <20220620120758.765049-1-trini@konsulko.com>
The symbol CONFIG_PCI_CLK_FREQ is local to this board. Provide equal
clarity in the code by referencing the numeric value directly and move
the explanatory comment to the code, just prior to use.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
board/socrates/socrates.c | 3 ++-
include/configs/socrates.h | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/socrates/socrates.c b/board/socrates/socrates.c
index 3430a1ed0178..27aad4eaae3a 100644
--- a/board/socrates/socrates.c
+++ b/board/socrates/socrates.c
@@ -59,7 +59,8 @@ int checkboard (void)
f = get_board_sys_clk();
} else {
src = "PCI_CLK";
- f = CONFIG_PCI_CLK_FREQ;
+ /* PCI is clocked by the external source at 33 MHz */
+ f = 33000000;
}
printf ("PCI1: 32 bit, %d MHz (%s)\n", f/1000000, src);
#else
diff --git a/include/configs/socrates.h b/include/configs/socrates.h
index 14f7bb9f7132..6a78cb1f2648 100644
--- a/include/configs/socrates.h
+++ b/include/configs/socrates.h
@@ -123,8 +123,6 @@
* Memory space is mapped 1-1.
*/
-/* PCI is clocked by the external source at 33 MHz */
-#define CONFIG_PCI_CLK_FREQ 33000000
#define CONFIG_SYS_PCI1_MEM_BASE 0x80000000
#define CONFIG_SYS_PCI1_MEM_PHYS CONFIG_SYS_PCI1_MEM_BASE
#define CONFIG_SYS_PCI1_MEM_SIZE 0x20000000 /* 512M */
--
2.25.1
next prev parent reply other threads:[~2022-06-20 12:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:07 [PATCH 01/17] Convert CONFIG_FSL_FIXED_MMC_LOCATION et al to Kconfig Tom Rini
2022-06-20 12:07 ` [PATCH 02/17] lcd: Remove legacy CONFIG_FB_ADDR code Tom Rini
2022-06-20 12:07 ` [PATCH 03/17] Convert CONFIG_LAYERSCAPE_NS_ACCESS to Kconfig Tom Rini
2022-06-20 12:07 ` [PATCH 04/17] Convert CONFIG_PCIE1 et al " Tom Rini
2022-06-20 12:07 ` [PATCH 05/17] Convert CONFIG_PCIE_IMX " Tom Rini
2022-06-20 12:07 ` [PATCH 06/17] pci: Remove pci_sh4 and related defines Tom Rini
2022-06-20 12:07 ` [PATCH 07/17] Convert CONFIG_PCI_SCAN_SHOW to Kconfig Tom Rini
2022-06-20 12:07 ` [PATCH 08/17] Convert CONFIG_PCI_GT64120 " Tom Rini
2022-06-20 12:07 ` [PATCH 09/17] Convert CONFIG_PCI_CONFIG_HOST_BRIDGE " Tom Rini
2022-06-20 12:07 ` [PATCH 10/17] m68k: Remove unused PCI code Tom Rini
2022-06-20 12:07 ` [PATCH 11/17] MPC837XERDB: Remove unused PCI defines Tom Rini
2022-06-20 12:07 ` [PATCH 12/17] Convert CONFIG_SH7751_PCI to Kconfig Tom Rini
2022-06-20 12:07 ` Tom Rini [this message]
2022-06-20 12:07 ` [PATCH 14/17] Convert CONFIG_PCI_MSC01 " Tom Rini
2022-06-20 12:07 ` [PATCH 15/17] Convert CONFIG_SYS_FSL_PCI_VER_3_X " Tom Rini
2022-06-20 12:07 ` [PATCH 16/17] qemu-ppce500: Move CONFIG_SYS_PCI_MAP_{START, END} to board code Tom Rini
2022-06-20 12:07 ` [PATCH 17/17] Convert CONFIG_KIRKWOOD_PCIE_INIT et al to Kconfig Tom Rini
2022-07-06 16:02 ` [PATCH 01/17] Convert CONFIG_FSL_FIXED_MMC_LOCATION " Tom Rini
2022-07-22 18:01 ` Tim Harvey
2022-07-22 19:06 ` Tom Rini
2022-07-22 20:05 ` Tim Harvey
2022-07-22 20:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620120758.765049-13-trini@konsulko.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox