From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25109C433EF for ; Mon, 20 Jun 2022 11:23:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2DD6806FF; Mon, 20 Jun 2022 13:23:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655724219; bh=guccNSGYe3Yy9yOPZ4bRtMp9z4q9Ekwji96wE7FPEuk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hlIFxkexJrGyfqJ0vj3N8TB14dh51GCML2+qPl6wEeGqM8koSngui5S8DOLqXWg5z EsJg/maCu0LC4xeJ60CstFp7agpFEu4bbEJowR0AKTjkCemcabPFxvRWQ+7he1tur3 gMfvGYdGfidJBe5Y4X1vUYN6tTmfcGAOvaXtB5xhxhtQS1jG8k8o0putSL7ct70wHL nGciqPe+sNln8RRuAwHp/G0btu7OUV57gwUAB6yDzqt/n0HoDd7XDix56tmou5Oe7A HWTc+sttvW/0hVRs3cfDu+eIgJr5isQECO9rRs+xUMq6v5O87S//MOjXqHG+bNBuXI bGAukMLlHfFuA== Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 41C2B8007F; Mon, 20 Jun 2022 13:23:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655724217; bh=guccNSGYe3Yy9yOPZ4bRtMp9z4q9Ekwji96wE7FPEuk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XA7oiVUTmm84f/sC+47Sw7XloPSx8QasUeuamflV52P/ObWZ4/UuZ+e6ct/+rYAC4 faccsnvUwQaFWEpl+mIE1upaY8R8Au2PRQBUJnwEtFV/J5MiPONpJVbrYQ4C2wtmQA V3dGpLcT2AQzLZC9/Nih4ao8XEffeLxzCsqRIjEqydvTLLA8asWVd5HwTM0Sr4W2ux jI9i3osz0RMU5B3na+89DLjC/gv4TQPzIi7H1q+49yOVFSKsNY+HJgaIfKAEmLO0jD Kdq4bOt5RQ++955n0WmvmJxuRMQESzLitf2K0fakUQxcPPDyTAQ7ogaK3BgmjBdVVT E/xzPDqvxRtpw== Date: Mon, 20 Jun 2022 13:23:31 +0200 From: Lukasz Majewski To: Jaehoon Chung Cc: u-boot@lists.denx.de Subject: Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration Message-ID: <20220620132331.167e2c9a@wsk> In-Reply-To: <20220620111354.448512-1-jh80.chung@samsung.com> References: <20220620111354.448512-1-jh80.chung@samsung.com> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ElnnH+nk8faf8hFsXb5/Xd3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Sig_/ElnnH+nk8faf8hFsXb5/Xd3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Jaehoon, > Add CONFIG_DFU_NAME_MAX_SIZE to change the proper size. > If name is longer than default size, it can do wrong behavior during > updating image. So it need to change the proper maximum size. >=20 > This patch is proviced the solution to change value with > configuration. >=20 > Signed-off-by: Jaehoon Chung > --- > drivers/dfu/Kconfig | 9 +++++++++ > include/dfu.h | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig > index 8d7f13dcb0b5..a181f0b8d7ba 100644 > --- a/drivers/dfu/Kconfig > +++ b/drivers/dfu/Kconfig > @@ -111,5 +111,14 @@ config SYS_DFU_MAX_FILE_SIZE > the buffer once we've been given the whole file. Define > this to the maximum filesize (in bytes) for the buffer. > If undefined it defaults to the > CONFIG_SYS_DFU_DATA_BUF_SIZE. + > +config DFU_NAME_MAX_SIZE > + int "Size of the name to be added in dfu entity" > + default 32 > + depends on DFU > + help > + This value is used to maximum size. If name is longer than > default size, > + we need to change the proper maximum size. > + > endif > endmenu > diff --git a/include/dfu.h b/include/dfu.h > index dcb9cd9d799a..948596f367d9 100644 > --- a/include/dfu.h > +++ b/include/dfu.h > @@ -99,7 +99,7 @@ struct virt_internal_data { > int dev_num; > }; > =20 > -#define DFU_NAME_SIZE 32 > +#define DFU_NAME_SIZE CONFIG_DFU_NAME_MAX_SIZE > #ifndef DFU_DEFAULT_POLL_TIMEOUT > #define DFU_DEFAULT_POLL_TIMEOUT 0 > #endif Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/ElnnH+nk8faf8hFsXb5/Xd3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmKwWLMACgkQAR8vZIA0 zr16eAf+M2F2MjvLFYHnNTP4a72gvuZ8jDlB9qowcXI7hl+g5h45fb3qdF4tovt4 SIkgJ7LT0NIQy+jCqrsGeNgXWVLNg2TD17vbBAxCPm8ltpr5fgHudglE5+yGwM0+ zoG/uer3kzllw2My1WaCIu9nJU2rxWP067UxXlKfutmDpEpQ3nJF7x7EY+Z0Az8W OZtbmbdYSKVIXZ/Wt6CpJErgNWO0Yn2jfvPTiQzDs2z5qryZYGJOoXit8nRLsuqK UvY9Dfh4uicG/ErXKj8EDTi98o5LnGGVQ0KJtVXFnpig7Mg118t+p8M1JgaBSF6J jp35wQb7/vEmT5XbDhJxDul1nFRp2A== =Wa2a -----END PGP SIGNATURE----- --Sig_/ElnnH+nk8faf8hFsXb5/Xd3--