From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A93B2C43334 for ; Tue, 21 Jun 2022 20:05:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26C09842E0; Tue, 21 Jun 2022 22:05:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Jpz79IXc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5F68C842DF; Tue, 21 Jun 2022 22:05:18 +0200 (CEST) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8562884300 for ; Tue, 21 Jun 2022 22:05:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-ej1-x62e.google.com with SMTP id lw20so7438684ejb.4 for ; Tue, 21 Jun 2022 13:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BaA1ZtBeV2OESQkQR5FyfC4IIgppTrYHqp814KHMa0=; b=Jpz79IXcsk5i7o+F4hoZvX59AAcrtGe882v7VbCmqASpo0wfC/l2EFB1cxz0GQb0MM lQTdMJU4Jx9Wy6D2WeSMjCW8V01wDjpGyEJnOLdVzgTOjZ+RZfoXIgyjN6yj+IRgBBIf xNiArE+TQgTTt8MhwtEtuFc1jkAOAfKvTAsa4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BaA1ZtBeV2OESQkQR5FyfC4IIgppTrYHqp814KHMa0=; b=W9bdAz9M75eJ8xpyJ17OI8QKdvJJUdoHNU/Q6ugWZ9/m33hfT/kNjF8IyVul5vNRqG DC9hvxArz2QshnFZuXQnnUfD/282WB3NV7QJfTKR/93lKqog8KKX+vG6UCyc5yFM01vt qIIjCCYxWkavUJ8X8twy0t+IF6y0wNzPF/v3WKr8t9WxK9cE/xLQieG4SraJ/w16RmRy pdVcv3Pejem2glL1zm9g+snf0TR5fgYw5Q/E3oCdrvtaI11FYq44XFsumwoDsH5JpUyx oCQFlMNUhr4xQQe2ukbrio0xsynqcUABKeZxzSkvOpR7hGgdL1yiZ6VarRN92o/3+ela EF5w== X-Gm-Message-State: AJIora/KbN85JKm/D0s0NaU5/0DrdTLROy3wmT1ZROnQAWJfMROrEGK3 PRKzwHS5MLHWa/mWCNKqDDOk1F6vacUgZtQ/ X-Google-Smtp-Source: AGRyM1ueym5CVW+6MDo+3sJKWStUHAnifg96sUqCNfjwvYI+VFHlBf2yxhAgXcoaqhlqPsQ/SJkKXw== X-Received: by 2002:a17:906:38ce:b0:715:8483:e02e with SMTP id r14-20020a17090638ce00b007158483e02emr76005ejd.442.1655841914660; Tue, 21 Jun 2022 13:05:14 -0700 (PDT) Received: from localhost.localdomain (mob-31-157-25-61.net.vodafone.it. [31.157.25.61]) by smtp.gmail.com with ESMTPSA id ek6-20020a056402370600b0042bdb6a3602sm12822977edb.69.2022.06.21.13.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 13:05:13 -0700 (PDT) From: Michael Trimarchi To: u-boot@lists.denx.de, Ye Li , Han Xu Cc: Andrea Scian , Stefano Babic Subject: [PATCH] mtd: mxs_nand_spl: fix nand_command protocol violation Date: Tue, 21 Jun 2022 22:05:10 +0200 Message-Id: <20220621200510.15988-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Andrea Scian mxs_nand_command() implementation assume that it's working with a LP NAND, which is a common case nowadays and thus uses two bytes for column address. However this is wrong for NAND_CMD_READID and NAND_CMD_PARAM, which expects only one byte of column address, even for LP NANDs. This leads to ONFI detection problem with some NAND manufacturer (like Winbond) but not with others (like Samsung and Spansion) We fix this with a simple workaround to avoid the 2nd byte column address for those two commands. Also align the code with nand_base to support 16 bit devices. Tested on an iMX6SX device with: * Winbond W29N04GVSIAA * Spansion S34ML04G100TF100 * Samsung K9F4G08U00 Tested on imx8mn device with: * Windbond W29N04GV Signed-off-by: Andrea Scian CC: Stefano Babic Signed-off-by: Michael Trimarchi --- drivers/mtd/nand/raw/mxs_nand_spl.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c index 2bfb181007..3daacbb330 100644 --- a/drivers/mtd/nand/raw/mxs_nand_spl.c +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c @@ -29,8 +29,20 @@ static void mxs_nand_command(struct mtd_info *mtd, unsigned int command, /* Serially input address */ if (column != -1) { + /* Adjust columns for 16 bit buswidth */ + if (chip->options & NAND_BUSWIDTH_16 && + !nand_opcode_8bits(command)) + column >>= 1; chip->cmd_ctrl(mtd, column, NAND_ALE); - chip->cmd_ctrl(mtd, column >> 8, NAND_ALE); + + /* + * Assume LP NAND here, so use two bytes column address + * but not for CMD_READID and CMD_PARAM, which require + * only one byte column address + */ + if (command != NAND_CMD_READID && + command != NAND_CMD_PARAM) + chip->cmd_ctrl(mtd, column >> 8, NAND_ALE); } if (page_addr != -1) { chip->cmd_ctrl(mtd, page_addr, NAND_ALE); -- 2.25.1