* [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display()
@ 2022-03-23 20:20 Andrew Scull
2022-05-15 18:55 ` Andrew Scull
2022-06-25 7:10 ` Anatolij Gustschin
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Scull @ 2022-03-23 20:20 UTC (permalink / raw)
To: u-boot; +Cc: Andrew Scull, Simon Glass, Anatolij Gustschin
Building the sandbox with NO_SDL=1 resulted in an undefined reference to
'sandbox_sdl_remove_display'. Resolve this by adding a stub
implementation to match the stubs of the other similar functions.
Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Anatolij Gustschin <agust@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
arch/sandbox/include/asm/sdl.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h
index e271a849af..56dcb84803 100644
--- a/arch/sandbox/include/asm/sdl.h
+++ b/arch/sandbox/include/asm/sdl.h
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
return -ENODEV;
}
+static inline int sandbox_sdl_remove_display(void)
+{
+ return -ENODEV;
+}
+
static inline int sandbox_sdl_sync(void *lcd_base)
{
return -ENODEV;
--
2.35.1.894.gb6a874cedc-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display()
2022-03-23 20:20 [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display() Andrew Scull
@ 2022-05-15 18:55 ` Andrew Scull
2022-06-22 16:37 ` Andrew Scull
2022-06-25 7:10 ` Anatolij Gustschin
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Scull @ 2022-05-15 18:55 UTC (permalink / raw)
To: U-Boot Mailing List; +Cc: Simon Glass, Anatolij Gustschin
Friendly ping on this patch as I've seen a few others being accepted
recently and wanted to make sure this fix hasn't fallen by the
wayside.
On Wed, 23 Mar 2022 at 20:20, Andrew Scull <ascull@google.com> wrote:
>
> Building the sandbox with NO_SDL=1 resulted in an undefined reference to
> 'sandbox_sdl_remove_display'. Resolve this by adding a stub
> implementation to match the stubs of the other similar functions.
>
> Signed-off-by: Andrew Scull <ascull@google.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Anatolij Gustschin <agust@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/sandbox/include/asm/sdl.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h
> index e271a849af..56dcb84803 100644
> --- a/arch/sandbox/include/asm/sdl.h
> +++ b/arch/sandbox/include/asm/sdl.h
> @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
> return -ENODEV;
> }
>
> +static inline int sandbox_sdl_remove_display(void)
> +{
> + return -ENODEV;
> +}
> +
> static inline int sandbox_sdl_sync(void *lcd_base)
> {
> return -ENODEV;
> --
> 2.35.1.894.gb6a874cedc-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display()
2022-05-15 18:55 ` Andrew Scull
@ 2022-06-22 16:37 ` Andrew Scull
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Scull @ 2022-06-22 16:37 UTC (permalink / raw)
To: U-Boot Mailing List; +Cc: Simon Glass, Anatolij Gustschin, Tom Rini
It's been a while, so pinging again.
On Sun, 15 May 2022 at 19:55, Andrew Scull <ascull@google.com> wrote:
> Friendly ping on this patch as I've seen a few others being accepted
> recently and wanted to make sure this fix hasn't fallen by the
> wayside.
>
> On Wed, 23 Mar 2022 at 20:20, Andrew Scull <ascull@google.com> wrote:
> >
> > Building the sandbox with NO_SDL=1 resulted in an undefined reference to
> > 'sandbox_sdl_remove_display'. Resolve this by adding a stub
> > implementation to match the stubs of the other similar functions.
> >
> > Signed-off-by: Andrew Scull <ascull@google.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Anatolij Gustschin <agust@denx.de>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > ---
> > arch/sandbox/include/asm/sdl.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/sandbox/include/asm/sdl.h
> b/arch/sandbox/include/asm/sdl.h
> > index e271a849af..56dcb84803 100644
> > --- a/arch/sandbox/include/asm/sdl.h
> > +++ b/arch/sandbox/include/asm/sdl.h
> > @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width,
> int height, int log2_bpp,
> > return -ENODEV;
> > }
> >
> > +static inline int sandbox_sdl_remove_display(void)
> > +{
> > + return -ENODEV;
> > +}
> > +
> > static inline int sandbox_sdl_sync(void *lcd_base)
> > {
> > return -ENODEV;
> > --
> > 2.35.1.894.gb6a874cedc-goog
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display()
2022-03-23 20:20 [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display() Andrew Scull
2022-05-15 18:55 ` Andrew Scull
@ 2022-06-25 7:10 ` Anatolij Gustschin
1 sibling, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2022-06-25 7:10 UTC (permalink / raw)
To: Andrew Scull; +Cc: u-boot, Simon Glass
On Wed, 23 Mar 2022 20:20:37 +0000
Andrew Scull ascull@google.com wrote:
> Building the sandbox with NO_SDL=1 resulted in an undefined reference to
> 'sandbox_sdl_remove_display'. Resolve this by adding a stub
> implementation to match the stubs of the other similar functions.
>
> Signed-off-by: Andrew Scull <ascull@google.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Anatolij Gustschin <agust@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/sandbox/include/asm/sdl.h | 5 +++++
> 1 file changed, 5 insertions(+)
applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-25 7:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-23 20:20 [PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display() Andrew Scull
2022-05-15 18:55 ` Andrew Scull
2022-06-22 16:37 ` Andrew Scull
2022-06-25 7:10 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox