public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: u-boot@lists.denx.de
Cc: "Ying-Chun Liu" <paul.liu@linaro.org>,
	"Peng Fan" <peng.fan@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Thomas Schäfer" <thomas.schaefer@kontron.com>,
	"Stefano Babic" <sbabic@denx.de>,
	"Alper Nebi Yasak" <alpernebiyasak@gmail.com>,
	"Heiko Thiery" <heiko.thiery@gmail.com>
Subject: [PATCH v3 2/2] ARM: imx: imx8mn-evk-common-u-boot.dtsi: cleanup
Date: Sun, 26 Jun 2022 11:59:39 +0200	[thread overview]
Message-ID: <20220626095937.142170-2-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20220626095937.142170-1-heiko.thiery@gmail.com>

This cleanup implements several review comments and its target is to
prepare for a common imx8mn-common-u-boot.dtsi for all imx8mn boards.
It includes changes in node names to use only dashes instead of
underscores, improve the odd bloob-ext naming, use the atf-bl31 type and
the use of of-list for multiple DTB support.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 arch/arm/dts/imx8mn-evk-common-u-boot.dtsi | 48 ++++++++++++++--------
 1 file changed, 31 insertions(+), 17 deletions(-)

diff --git a/arch/arm/dts/imx8mn-evk-common-u-boot.dtsi b/arch/arm/dts/imx8mn-evk-common-u-boot.dtsi
index d5ea2dcb4e..f512be095c 100644
--- a/arch/arm/dts/imx8mn-evk-common-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-evk-common-u-boot.dtsi
@@ -153,44 +153,52 @@
 		};
 
 #ifdef CONFIG_IMX8M_DDR4
-		blob_1: blob-ext@1 {
+		1d-imem {
 			filename = "ddr4_imem_1d_201810.bin";
 			size = <0x8000>;
+			type = "blob-ext";
 		};
 
-		blob_2: blob-ext@2 {
+		1d-dmem {
 			filename = "ddr4_dmem_1d_201810.bin";
 			size = <0x4000>;
+			type = "blob-ext";
 		};
 
-		blob_3: blob-ext@3 {
+		2d-imem {
 			filename = "ddr4_imem_2d_201810.bin";
 			size = <0x8000>;
+			type = "blob-ext";
 		};
 
-		blob_4: blob-ext@4 {
+		2d-dmem {
 			filename = "ddr4_dmem_2d_201810.bin";
 			size = <0x4000>;
+			type = "blob-ext";
 		};
 #elif CONFIG_IMX8M_LPDDR4
-		blob_1: blob-ext@1 {
+		1d-imem {
 			filename = "lpddr4_pmu_train_1d_imem.bin";
 			size = <0x8000>;
+			type = "blob-ext";
 		};
 
-		blob_2: blob-ext@2 {
+		1d-dmem {
 			filename = "lpddr4_pmu_train_1d_dmem.bin";
 			size = <0x4000>;
+			type = "blob-ext";
 		};
 
-		blob_3: blob-ext@3 {
+		2d-imem {
 			filename = "lpddr4_pmu_train_2d_imem.bin";
 			size = <0x8000>;
+			type = "blob-ext";
 		};
 
-		blob_4: blob-ext@4 {
+		2d-dmem {
 			filename = "lpddr4_pmu_train_2d_dmem.bin";
 			size = <0x4000>;
+			type = "blob-ext";
 		};
 #else
 	#error "no valid ddr config selected"
@@ -216,6 +224,7 @@
 		fit {
 			description = "Configuration to load ATF before U-Boot";
 			#address-cells = <1>;
+			fit,fdt-list = "of-list";
 			fit,external-offset = <CONFIG_FIT_EXTERNAL_OFFSET>;
 
 			images {
@@ -226,8 +235,9 @@
 					compression = "none";
 					load = <CONFIG_SYS_TEXT_BASE>;
 
-					uboot_blob: blob-ext {
+					uboot-blob {
 						filename = "u-boot-nodtb.bin";
+						type = "blob-ext";
 					};
 				};
 
@@ -239,30 +249,32 @@
 					load = <0x960000>;
 					entry = <0x960000>;
 
-					atf_blob: blob-ext {
+					atf-blob {
 						filename = "bl31.bin";
+						type = "atf-bl31";
 					};
 				};
 
-				fdt {
+				@fdt-SEQ {
 					description = "NAME";
 					type = "flat_dt";
 					compression = "none";
 
-					uboot_fdt_blob: blob-ext {
+					uboot-fdt-blob {
 						filename = "u-boot.dtb";
+						type = "blob-ext";
 					};
 				};
 			};
 
 			configurations {
-				default = "conf";
+				default = "@config-DEFAULT-SEQ";
 
-				conf {
+				binman_configuration: @config-SEQ {
 					description = "NAME";
 					firmware = "uboot";
 					loadables = "atf";
-					fdt = "fdt";
+					fdt = "fdt-SEQ";
 				};
 			};
 		};
@@ -272,14 +284,16 @@
 		filename = "flash.bin";
 		pad-byte = <0x00>;
 
-		spl: blob-ext@1 {
+		spl {
 			offset = <0x0>;
 			filename = "spl.bin";
+			type = "blob-ext";
 		};
 
-		uboot: blob-ext@2 {
+		binman_uboot: uboot {
 			offset = <0x58000>;
 			filename = "u-boot.itb";
+			type = "blob-ext";
 		};
 	};
 };
-- 
2.30.2


      reply	other threads:[~2022-06-26 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26  9:59 [PATCH v3 1/2] ARM: imx: imx8mn-evk: use one common u-boot.dtsi for the evk boards Heiko Thiery
2022-06-26  9:59 ` Heiko Thiery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220626095937.142170-2-heiko.thiery@gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=festevam@gmail.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marek.vasut@gmail.com \
    --cc=paul.liu@linaro.org \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=seanga2@gmail.com \
    --cc=tharvey@gateworks.com \
    --cc=thomas.schaefer@kontron.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox