* [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n
@ 2022-05-11 0:03 Samuel Holland
2022-05-11 8:57 ` Andre Przywara
2022-06-27 0:11 ` Andre Przywara
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Holland @ 2022-05-11 0:03 UTC (permalink / raw)
To: u-boot, Jagan Teki, Andre Przywara
Cc: Samuel Holland, Eddie James, Heiko Schocher, Michal Simek,
Oleksandr Suvorov, Philippe Reynes, Sebastian Reichel,
Simon Glass, T Karthik Reddy
This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit
88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO
was always selected indirectly. Now it is not, so select it here.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 89068c7800..b955543e97 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT
config SUNXI_GPIO
bool "Allwinner GPIO driver"
depends on ARCH_SUNXI
+ select SPL_STRTO if SPL
help
Support the GPIO device in Allwinner SoCs.
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n
2022-05-11 0:03 [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n Samuel Holland
@ 2022-05-11 8:57 ` Andre Przywara
2022-06-27 0:11 ` Andre Przywara
1 sibling, 0 replies; 3+ messages in thread
From: Andre Przywara @ 2022-05-11 8:57 UTC (permalink / raw)
To: Samuel Holland
Cc: u-boot, Jagan Teki, Eddie James, Heiko Schocher, Michal Simek,
Oleksandr Suvorov, Philippe Reynes, Sebastian Reichel,
Simon Glass, T Karthik Reddy
On Tue, 10 May 2022 19:03:34 -0500
Samuel Holland <samuel@sholland.org> wrote:
Hi,
> This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit
> 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO
> was always selected indirectly. Now it is not, so select it here.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
From what I can see, CONFIG_MMC is the trigger, calling
sunxi_name_to_gpio(), which is the actual user of simple_strtol() in the
SPL. For the three boards not using MMC I don't see simple_strol() being
mentioned in the objdump.
But I think this patch is a more robust solution (compared to tying it to
MMC usage), so:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 89068c7800..b955543e97 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT
> config SUNXI_GPIO
> bool "Allwinner GPIO driver"
> depends on ARCH_SUNXI
> + select SPL_STRTO if SPL
> help
> Support the GPIO device in Allwinner SoCs.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n
2022-05-11 0:03 [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n Samuel Holland
2022-05-11 8:57 ` Andre Przywara
@ 2022-06-27 0:11 ` Andre Przywara
1 sibling, 0 replies; 3+ messages in thread
From: Andre Przywara @ 2022-06-27 0:11 UTC (permalink / raw)
To: Samuel Holland
Cc: u-boot, Jagan Teki, Eddie James, Heiko Schocher, Michal Simek,
Oleksandr Suvorov, Philippe Reynes, Sebastian Reichel,
Simon Glass, T Karthik Reddy
On Tue, 10 May 2022 19:03:34 -0500
Samuel Holland <samuel@sholland.org> wrote:
> This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit
> 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO
> was always selected indirectly. Now it is not, so select it here.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied to sunxi/master, for v2022.07.
Thanks,
Andre
> ---
>
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 89068c7800..b955543e97 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT
> config SUNXI_GPIO
> bool "Allwinner GPIO driver"
> depends on ARCH_SUNXI
> + select SPL_STRTO if SPL
> help
> Support the GPIO device in Allwinner SoCs.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-27 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-11 0:03 [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n Samuel Holland
2022-05-11 8:57 ` Andre Przywara
2022-06-27 0:11 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox