public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steven Lee <steven_lee@aspeedtech.com>
To: Joel Stanley <joel@jms.id.au>
Cc: "Cédric Le Goater" <clg@kaod.org>,
	"ChiaWei Wang" <chiawei_wang@aspeedtech.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	"Ryan Chen" <ryan_chen@aspeedtech.com>,
	BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH 3/5] config/ast2600: Disable hash hardware accel
Date: Tue, 28 Jun 2022 11:11:35 +0800	[thread overview]
Message-ID: <20220628031134.GA8861@aspeedtech.com> (raw)
In-Reply-To: <CACPK8XejMWtqNgwo-xpmdnLsoTDeJ=oS80Zk9q6kY6O7AfhcoA@mail.gmail.com>

The 06/27/2022 18:06, Joel Stanley wrote:
> On Mon, 27 Jun 2022 at 08:48, Steven Lee <steven_lee@aspeedtech.com> wrote:
> >
> > Hi Joel,
> >
> > I was wondering if you could share the commit hash of u-boot you tested.
> > I would like to test it on qemu.
> 
> I recommend using master with the patch that fixes FIT hash checking:
> 
> https://lore.kernel.org/r/20220620070117.3443066-1-joel@jms.id.au
> 
> I use a script to build the image (also attached to this email):
> 
> https://ozlabs.org/~joel/build-ast2600-spl.sh
> 
> Run that script from the u-boot source tree. It provides an example
> qemu commandline when it finishes:

Hi Joel,

Thanks for providing the information.
It seems that 2022.07 hace driver calculating hash by direct access +
accumulative mode, and aspeedtech-bmc uboot calculating hash by
scatter-gather + accumulative mode.

Currently, qemu only supports scatter-gather + accumulative mode.
https://github.com/qemu/qemu/blob/master/hw/misc/aspeed_hace.c#L197-L224

Reference:
U-Boot SPL 2022.07-rc5-08402-gad4f0cd35a:
https://github.com/shenki/u-boot/blob/aspeed-test/drivers/crypto/aspeed/aspeed_hace.c#L125

AspeedTech-BMC:
https://github.com/AspeedTech-BMC/u-boot/blob/aspeed-master-v2019.04/drivers/crypto/aspeed_hace.c#L165

Regards,
Steven

  reply	other threads:[~2022-06-28 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  2:50 [PATCH 0/5] aspeed: Add to CI Joel Stanley
2022-06-24  2:50 ` [PATCH 1/5] config/ast2600: Enable CRC32 Joel Stanley
2022-06-24  2:50 ` [PATCH 2/5] config/ast2600: Make position independent Joel Stanley
2022-06-24  2:50 ` [PATCH 3/5] config/ast2600: Disable hash hardware accel Joel Stanley
2022-06-27  0:39   ` ChiaWei Wang
2022-06-27  7:11     ` Cédric Le Goater
2022-06-27  7:39       ` Joel Stanley
2022-06-27  8:48         ` Steven Lee
2022-06-27 10:06           ` Joel Stanley
2022-06-28  3:11             ` Steven Lee [this message]
2022-06-24  2:50 ` [PATCH 4/5] ast2600: Configure u-boot-with-spl.bin target Joel Stanley
2022-06-27  0:41   ` ChiaWei Wang
2022-06-24  2:50 ` [PATCH 5/5] CI: Add Aspeed AST2600 Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628031134.GA8861@aspeedtech.com \
    --to=steven_lee@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=ryan_chen@aspeedtech.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox