From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35322C433EF for ; Tue, 28 Jun 2022 13:26:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 274D683A31; Tue, 28 Jun 2022 15:26:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 42E97843D8; Tue, 28 Jun 2022 05:12:49 +0200 (CEST) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFFD5843AC for ; Tue, 28 Jun 2022 05:12:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=steven_lee@aspeedtech.com Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 25S2trqT061499; Tue, 28 Jun 2022 10:55:53 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.70.100) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Jun 2022 11:11:52 +0800 Date: Tue, 28 Jun 2022 11:11:35 +0800 From: Steven Lee To: Joel Stanley CC: =?utf-8?Q?C=C3=A9dric?= Le Goater , ChiaWei Wang , "u-boot@lists.denx.de" , Ryan Chen , BMC-SW Subject: Re: [PATCH 3/5] config/ast2600: Disable hash hardware accel Message-ID: <20220628031134.GA8861@aspeedtech.com> References: <20220624025017.3926528-1-joel@jms.id.au> <20220624025017.3926528-4-joel@jms.id.au> <286c6c36-2123-579e-b8da-d0c87547a9b3@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.70.100] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 25S2trqT061499 X-Mailman-Approved-At: Tue, 28 Jun 2022 15:25:58 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The 06/27/2022 18:06, Joel Stanley wrote: > On Mon, 27 Jun 2022 at 08:48, Steven Lee wrote: > > > > Hi Joel, > > > > I was wondering if you could share the commit hash of u-boot you tested. > > I would like to test it on qemu. > > I recommend using master with the patch that fixes FIT hash checking: > > https://lore.kernel.org/r/20220620070117.3443066-1-joel@jms.id.au > > I use a script to build the image (also attached to this email): > > https://ozlabs.org/~joel/build-ast2600-spl.sh > > Run that script from the u-boot source tree. It provides an example > qemu commandline when it finishes: Hi Joel, Thanks for providing the information. It seems that 2022.07 hace driver calculating hash by direct access + accumulative mode, and aspeedtech-bmc uboot calculating hash by scatter-gather + accumulative mode. Currently, qemu only supports scatter-gather + accumulative mode. https://github.com/qemu/qemu/blob/master/hw/misc/aspeed_hace.c#L197-L224 Reference: U-Boot SPL 2022.07-rc5-08402-gad4f0cd35a: https://github.com/shenki/u-boot/blob/aspeed-test/drivers/crypto/aspeed/aspeed_hace.c#L125 AspeedTech-BMC: https://github.com/AspeedTech-BMC/u-boot/blob/aspeed-master-v2019.04/drivers/crypto/aspeed_hace.c#L165 Regards, Steven