From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C8E9C43334 for ; Tue, 28 Jun 2022 14:19:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 486F08408D; Tue, 28 Jun 2022 16:19:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="k6KIUR7p"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C846883EA0; Tue, 28 Jun 2022 16:19:02 +0200 (CEST) Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E0708408D for ; Tue, 28 Jun 2022 16:18:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x535.google.com with SMTP id q140so12350463pgq.6 for ; Tue, 28 Jun 2022 07:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=y+/JklVgBkAvvg1DrXyKdMpHhivYVwqvl4rO3FiuTBo=; b=k6KIUR7p5wYStdQipj+04qpWgQEVYyiC3m6O+/EstSk36F8qTfIo0u1oqO/qYkkyOf jDFmisK6MogZFBEDsdk+ZnjsHE3waxSdSQb6wphmE8Yr2kL3sE8SPJaHpAVnwUImpmgS zVjUqnYMnobhz2+4gOXDX6+W3A8WMxNwx69UHvdpieaQX6wpP3VqplnNimA82Z8tkT6K tMEeAbf7vquRfpgg0wD+AK7ZIiYi1yaZyuxeRr5YqlLU/J0qwbKKH/QMNxDhQsOKlWzF ljwYCQDyyoQV3cKErEIZ2afvwZJ2nhQY97c7z7FjPdmlGtzuV/KyDI2bywFY0zwq/hof p9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=y+/JklVgBkAvvg1DrXyKdMpHhivYVwqvl4rO3FiuTBo=; b=GIngwxBvmlVRDm2W7mjRtWJLiyDFp1mSCu0SVYx0rjFe7vsNy2OuDdELpIOoz+TluM 3RRnlxnmG27zs2T2YjrNUWFuQq7L51eHKg9jVeNHrww99TwTbNUz6BJa1BhjbNAoJEwn 7bM5YpwFBTxSlo9BYWuv0CmbD3ORuebffwsUWIVnlvoLTN8mTE9bInkAkzX6JRA0mRX1 S8iVTyC6T6XWY5DuuqCm3PJhNa/7Q64a/P4++Fs1T1WvBfqZ8l7BjQkf9EjsFEDc28HP 85JnkW+MQZMFaY+4kQB/ZZpuDJT19/zjPMGW74lSGLy6+JvH/aJWoHWnpA0qu+w8vD5E Fbgg== X-Gm-Message-State: AJIora/MqHAEc5JBIL3vGh3NB8MzkkqkcAcchjLXhlmdYtYQF01GaxFz uhN0iH2FLIVLLJ76Pb0061HJwg== X-Google-Smtp-Source: AGRyM1v9CxWQE/VKFGJtcbmtChNP6Kq029x5PTGm7AXLaiLHoeZ+iVHfyqC6+b72p+uTHComA26DVg== X-Received: by 2002:a05:6a00:10d4:b0:522:8c31:ec23 with SMTP id d20-20020a056a0010d400b005228c31ec23mr3928766pfu.67.1656425935850; Tue, 28 Jun 2022 07:18:55 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:f10c:7996:55bb:3621]) by smtp.gmail.com with ESMTPSA id u9-20020a170902e5c900b0016760c06b76sm1014008plf.194.2022.06.28.07.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 07:18:55 -0700 (PDT) Date: Tue, 28 Jun 2022 23:18:51 +0900 From: AKASHI Takahiro To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , U-Boot Custodians , Marek Vasut , Pavel Herrmann Subject: Re: [PATCH 6/9] dm: core: Support accessing core tags Message-ID: <20220628141851.GA90541@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , U-Boot Mailing List , Tom Rini , U-Boot Custodians , Marek Vasut , Pavel Herrmann References: <20220509045226.GA34398@laputa> <20220508103927.912854-1-sjg@chromium.org> <20220508103927.912854-7-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote: > Hi Simon, > > On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote: > > At present tag numbers are only allocated for non-core data, meaning that > > the 'core' data, like priv and plat, are accessed through dedicated > > functions. > > > > For debugging and consistency it is convenient to use tags for this 'core' > > data too. Add support for this, with new tag numbers and functions to > > access the pointer and size for each. > > > > Update one of the test drivers so that the uclass-private data can be > > tested here. > > > > There is some code duplication with functions like device_alloc_priv() but > > this is not addressed for now. At some point, some rationalisation may > > help to reduce code size, but more thought it needed on that. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/core/device.c | 65 +++++++++++++++++++++++++++++++++ > > drivers/misc/test_drv.c | 4 ++- > > include/dm/device.h | 25 +++++++++++++ > > include/dm/tag.h | 13 ++++++- > > test/dm/core.c | 80 +++++++++++++++++++++++++++++++++++++++++ > > tools/dtoc/test_dtoc.py | 4 +++ > > 6 files changed, 189 insertions(+), 2 deletions(-) > > > Applied to u-boot-dm, thanks! I expect you to reply to my comments: https://lists.denx.de/pipermail/u-boot/2022-May/483606.html -Takahiro Akashi