From: "Pali Rohár" <pali@kernel.org>
To: "Priyanka Jain (OSS)" <priyanka.jain@oss.nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Tom Rini <trini@konsulko.com>
Cc: Qiang Zhao <qiang.zhao@nxp.com>,
Shengzhou Liu <shengzhou.liu@nxp.com>,
Alexander Graf <agraf@csgraf.de>, Bin Meng <bmeng.cn@gmail.com>,
Wolfgang Denk <wd@denx.de>, Sinan Akman <sinan@writeme.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector
Date: Tue, 28 Jun 2022 20:07:48 +0200 [thread overview]
Message-ID: <20220628180748.rhigdsaik7a64trr@pali> (raw)
In-Reply-To: <20220623171755.2qkrxy55qrbuvxbr@pali>
On Thursday 23 June 2022 19:17:55 Pali Rohár wrote:
> On Saturday 04 June 2022 15:02:38 Pali Rohár wrote:
> > On Wednesday 18 May 2022 12:53:20 Pali Rohár wrote:
> > > On Wednesday 11 May 2022 22:59:28 Pali Rohár wrote:
> > > > On Monday 25 April 2022 14:36:14 Pali Rohár wrote:
> > > > > On Monday 25 April 2022 05:25:34 Priyanka Jain (OSS) wrote:
> > > > > > >-----Original Message-----
> > > > > > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Pali Rohár
> > > > > > >Sent: Tuesday, April 5, 2022 7:11 PM
> > > > > > >To: Priyanka Jain <priyanka.jain@nxp.com>; Qiang Zhao <qiang.zhao@nxp.com>;
> > > > > > >Shengzhou Liu <shengzhou.liu@nxp.com>; Alexander Graf <agraf@csgraf.de>;
> > > > > > >Bin Meng <bmeng.cn@gmail.com>; Wolfgang Denk <wd@denx.de>; Sinan
> > > > > > >Akman <sinan@writeme.com>
> > > > > > >Cc: u-boot@lists.denx.de
> > > > > > >Subject: [PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre-
> > > > > > >PBL eSDHC boot sector
> > > > > > >
> > > > > > >QorIQ U-Boot binary for SD card booting compiled during build process (either u-
> > > > > > >boot.bin or u-boot-with-spl.bin) cannot be directly loaded by QorIQ pre-PBL
> > > > > > >BootROM. Compiled U-Boot binary first needs to be processed by Freescale
> > > > > > >boot_format tool as described in doc/README.mpc85xx-sd-spi-boot
> > > > > > >
> > > > > > >BootROM requires that image on SD card must contain special boot sector.
> > > > > > >Implement support for generating this special boot sector directly in U-Boot start
> > > > > > >code. Boot sector needs to be at the beginning of the image, so when compiling
> > > > > > >only proper U-Boot without SPL then it needs to be in proper U-Boot. When
> > > > > > >compiling SPL with proper U-Boot then it needs to be only in SPL.
> > > > > > >
> > > > > > >Support can be enabled by a new config option
> > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR.
> > > > > > >Via other two additional options FSL_PREPBL_ESDHC_BOOT_SECTOR_START and
> > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR_DATA it is possible to tune how final U-Boot
> > > > > > >image could be stored on the SD card.
> > > > > > >
> > > > > > >Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > > > >---
> > > > > >
> > > > > > Kindly rebase the series to master.
> > > > > >
> > > > > > Regards
> > > > > > Priyanka
> > > > >
> > > > > Hello! Both patches still applies cleanly on master, just they depend
> > > > > on another patch series (powerpc: mpc85xx: Fix and cleanup mpc85xx code)
> > > > > which I mentioned in cover letter and therefore needs V2 patch of
> > > > > "powerpc: mpc85xx: Set TEXT_BASE addresses to real base values" which I
> > > > > sent recently.
> > > >
> > > > I sent a new version v2 of this patch, see email:
> > > > [PATCH v2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector
> > >
> > > Priyanka: PING
> >
> > PING?
>
> PING?
PING?
V2 now and still applies cleanly on top of next branch
https://patchwork.ozlabs.org/project/uboot/patch/20220511185731.3000-1-pali@kernel.org/
And why v2 has "Changes Requested" state in above patchwork?
I do not see any comment for v2 on mailing list nor on patchwork.
So what is requested from me?
next prev parent reply other threads:[~2022-06-28 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:40 [PATCH 0/2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector Pali Rohár
2022-04-05 13:40 ` [PATCH 1/2] " Pali Rohár
2022-04-25 5:25 ` Priyanka Jain (OSS)
2022-04-25 12:36 ` Pali Rohár
2022-05-11 20:59 ` Pali Rohár
2022-05-18 10:53 ` Pali Rohár
2022-06-04 13:02 ` Pali Rohár
2022-06-23 17:17 ` Pali Rohár
2022-06-28 18:07 ` Pali Rohár [this message]
2022-06-28 18:14 ` Tom Rini
2022-07-13 23:49 ` Pali Rohár
2022-07-21 22:49 ` Pali Rohár
2022-05-11 18:57 ` [PATCH v2] " Pali Rohár
2022-04-05 13:40 ` [PATCH 2/2] board: freescale: p1_p2_rdb_pc: Calculate offsets for " Pali Rohár
2022-08-01 12:50 ` [PATCH v2] " Pali Rohár
2022-08-17 21:03 ` Pali Rohár
2022-09-07 3:02 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628180748.rhigdsaik7a64trr@pali \
--to=pali@kernel.org \
--cc=agraf@csgraf.de \
--cc=bmeng.cn@gmail.com \
--cc=peng.fan@oss.nxp.com \
--cc=priyanka.jain@oss.nxp.com \
--cc=qiang.zhao@nxp.com \
--cc=shengzhou.liu@nxp.com \
--cc=sinan@writeme.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox