Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

Lee Jones
2022-06-27T08:39:46Z

On Tue, 21 Jun 2022, Lee Jones wrote:

> Functions pointed to by this op pointer can return non-zero values
> indicating an error. Ensure any error value is propagated back up the
> call-chain.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Weekly check-in:

Are these still on someone's radar, or would you like me to [RESEND]?

> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index c0a06dcaed..0af0fa9e7b 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -3005,7 +3005,9 @@ static int sdram_init(struct dram_info *dram,
> params->base.stride = calculate_stride(params);
> dram_all_config(dram, params);
>
> - dram->ops->set_rate_index(dram, params);
> + ret = dram->ops->set_rate_index(dram, params);
> + if (ret)
> + return ret;
>
> debug("Finish SDRAM initialization...\n");
> return 0;

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog