Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

Lee Jones
2022-07-04T09:24:03Z

On Fri, 01 Jul 2022, Kever Yang wrote:

> Hi Lee Jones,
>
>
> On 2022/6/27 16:39, Lee Jones wrote:
> > On Tue, 21 Jun 2022, Lee Jones wrote:
> >
> > > Functions pointed to by this op pointer can return non-zero values
> > > indicating an error. Ensure any error value is propagated back up the
> > > call-chain.
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > Weekly check-in:
> >
> > Are these still on someone's radar, or would you like me to [RESEND]?
>
> It would be better to add leading message "rockchip:" in the subject.

That would be highly unusual.

Patch subjects are usually formed, as follows:

"<subsystem>: <device>: <description>"

I only see 2 RAM-only patches (out of the 91 that touch this file)
that do as you suggested and you were the author of both of them. :)

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog