From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CED4BC43334 for ; Wed, 6 Jul 2022 01:07:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23E0A8437C; Wed, 6 Jul 2022 03:07:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZJOgo+DD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B7F6843AF; Wed, 6 Jul 2022 03:07:15 +0200 (CEST) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C38C4805FE for ; Wed, 6 Jul 2022 03:07:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1035.google.com with SMTP id x18-20020a17090a8a9200b001ef83b332f5so8417012pjn.0 for ; Tue, 05 Jul 2022 18:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=tZ2aZKJlQkFGeZJDmXEvTgd/a42TEnyjnf1blYa7zhg=; b=ZJOgo+DDaIEkvZjOroq0CdVqdbesh2abDZRBsQtCUuyIzFQu8E7CiQ10r8clWQzSdb zbMHy9Ru6KyhyNSQadW6V5haAn7gcEDd3HofyIkvZM3msHi3iDJ0hM0Mv18z0lXkmlM/ JZ6bZK+9NBBaJwQJagRiF4+DdL8FsV3c7voGnpKeWlkFYjgDHxBmbIMdrVMgn/dzOlN0 rUwVjfzqT/AJrIZiX19AJfSjICSmP/XeLXRxLXmueSbiKWSMdConXjHN911sVmtqHQj9 syWObZYyD1n8lXpt8a7lbEBKYczUILQER0P0sHMmEUFjG9l5T0OgUuhbEm/KfZ1Q1+1K yiwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=tZ2aZKJlQkFGeZJDmXEvTgd/a42TEnyjnf1blYa7zhg=; b=4wciRVSBq7dnv4denDj03fQD6IEnKl4Tm38xHKVDbIxBXuVK62/oprKeDq5HTn9Ua2 wgLOR+cm2CVvn1B80ck3gGsLmjAn/Jg0dtq4iJJqzFbU/XY/nQ21d19pv/gk3rt3UfoM Hc/f+akgP0niI9cQ4+IQLb3aP2msue5GAFhrOL1g+LuI3xC42AzYSNUTNOVxWRzDrH/G MDtLpkluhjWKUBKhOIkSCVhr2ayF8vDAhIBGAmIv9FSx5ahCR1EE+N5RutNWKcwheNGA KTog2b4wgUStqPD4EV6uqWRS2eFBnkS84e7dAarXvb3GxId1rqaVsY/jzcg+wX7yd8ZS dBRw== X-Gm-Message-State: AJIora8UjFV4alJZgdO3R5fYnD60QGmnCt7yccnAbnAXFLJtZxs5sSXt 79XiyG3tg9ZjV6BqfL28RkOAQg== X-Google-Smtp-Source: AGRyM1vJmyWOa8UZBb+5JQEM5dJFEycA/gpGX6F5rKCcMIl8bZnG3PdmwPGgP1W6/p8aCd1JYktuTA== X-Received: by 2002:a17:902:bd01:b0:16a:65a5:9761 with SMTP id p1-20020a170902bd0100b0016a65a59761mr44827768pls.3.1657069629679; Tue, 05 Jul 2022 18:07:09 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:a4a2:c8c3:a3dd:4eca]) by smtp.gmail.com with ESMTPSA id u8-20020a170903124800b0016bd8f66ca0sm6700412plh.162.2022.07.05.18.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 18:07:08 -0700 (PDT) Date: Wed, 6 Jul 2022 10:07:05 +0900 From: AKASHI Takahiro To: "Jason A. Donenfeld" Cc: xypron.glpk@gmx.de, ilias.apalodimas@linaro.org, baocheng.su@siemens.com, jan.kiszka@siemens.com, u-boot@lists.denx.de Subject: Re: [PATCH 1/5] lib: crypto: add mscode_parser Message-ID: <20220706010705.GA42673@laputa> Mail-Followup-To: AKASHI Takahiro , "Jason A. Donenfeld" , xypron.glpk@gmx.de, ilias.apalodimas@linaro.org, baocheng.su@siemens.com, jan.kiszka@siemens.com, u-boot@lists.denx.de References: <20220705054815.30318-1-takahiro.akashi@linaro.org> <20220705054815.30318-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On Tue, Jul 05, 2022 at 03:13:17PM +0200, Jason A. Donenfeld wrote: > On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote: > > + This option provides support for parsing MicroSoft's Authenticode > > + in pkcs7 message. > > I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a > wink, but here too... haha ummm. We could change it to "MikeRoweSoft" > instead in honor of the Belmont High School student. But... I think I have never heard of his name, but > "Microsoft" is what you're after here. If so, yes. > > + pr_devel("Data: %zu [%*ph]\n", data_len, (unsigned)(data_len), > > + content_data); > > That's a weird cast around (data_len), but are you sure you want to keep > that print line in there? My basic policy in importing a file form Linux, as far as lib/crypto/*.c is concerned, is not to modify the original code unless it's harmful but to add "#ifndef __UBOOT__" to exclude useless or never-used code so that someone else other than me can easily synchronize files again in the future. So even if it looks weird (and checkpatch.pl, which ironically comes from Linux as well, might raise warnings), I'd like to leave it as it is. Having said that, if maintainers have a different policy, I don't hesitate to follow it. Thanks, -Takahiro Akashi > Jason