Re: [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

On Sun, Jul 10, 2022 at 01:42:56PM +0200, Pali Rohár wrote:

> CONFIG_PREBOOT just cause putting "preboot=CONFIG_PREBOOT" into env list.
> Value CONFIG_PREBOOT="run preboot" in defconfig is just nonsense and does
> not do anything useful (it is infinite recursion). Config file for this
> board already contains default preboot= env variable with correct value,
> which has higher priority than CONFIG_PREBOOT and this is reason why
> nonsense CONFIG_PREBOOT is ignored.
> 
> Remove nonsense and unused CONFIG_PREBOOT from nokia_rx51_defconfig file.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  configs/nokia_rx51_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
> index 309cf28269c1..46b794f168d9 100644
> --- a/configs/nokia_rx51_defconfig
> +++ b/configs/nokia_rx51_defconfig
> @@ -24,7 +24,6 @@ CONFIG_AUTOBOOT_MENU_SHOW=y
>  CONFIG_USE_BOOTCOMMAND=y
>  CONFIG_BOOTCOMMAND="run sdboot;run emmcboot;run attachboot;echo"
>  CONFIG_USE_PREBOOT=y
> -CONFIG_PREBOOT="run preboot"
>  # CONFIG_SYS_DEVICE_NULLDEV is not set
>  CONFIG_HUSH_PARSER=y
>  CONFIG_SYS_PROMPT="Nokia RX-51 # "

These changes are actually a bit puzzling.  There are other platforms
that set preboot in their default environment, rather than via
CONFIG_PREBOOT, and their final value ends up being the one set in
CONFIG_EXTRA_ENV_SETTINGS rather than the empty string that
CONFIG_PREBOOT is.  I assume you've confirmed that at run-time you end
up with preboot="run preboot" being set, and not preboot="long command"
?  The difference between nokia_rx51 and the other platforms is, I
think, LTO being enabled and maybe that leads to a different final value
in the resulting environment.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]