From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3638C433EF for ; Wed, 13 Jul 2022 09:55:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B8E1184474; Wed, 13 Jul 2022 11:54:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=fris.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=fris.de header.i=@fris.de header.b="PE3qq6Fe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8D3D784334; Wed, 13 Jul 2022 11:53:37 +0200 (CEST) Received: from mail.fris.de (mail.fris.de [IPv6:2a01:4f8:c2c:390b::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 350EC84417 for ; Wed, 13 Jul 2022 11:53:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=fris.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frieder@fris.de Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 592D6BFABE; Wed, 13 Jul 2022 11:53:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1657705995; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=zZLDHpw0Nxr4ewVlL89Iz9CjcBOjjRhd1jUkCvnprYk=; b=PE3qq6FewJj6FOjZT3hTWa7koNoHj7wANaugrYrrOouzOzNc/VKnuV+nbggXsLLKy+5COK 9jj5Mw2nWWT0z6d2Mfj/7kGD7SgRQw6TN1EwYafmTFCLR0EHdlcjyv3Z8wSta2XD6/h4UZ zNcOOHA4CKA4PZXhQHqCkbIrPenzMaP5tv9eoLJgbOmEY5EgdVifk/8S8LS8hZPTKtcKgJ z1Jdn7p6KNOJ6wWvntGyaRiQNAMPpG7QAgxo8O3poDPiUXdHFQCnlHFY9OnC6xdL6327ko OtPbPAT/BFXtAvNRELAL6y+nxH7VNZos2Mqpf7rLn4L5XfFhIOawmbSNANeaHQ== From: Frieder Schrempf To: Frieder Schrempf , u-boot@lists.denx.de Cc: Fabio Estevam , Peng Fan , Stefano Babic Subject: [PATCH 13/14] imx: kontron-sl-mx8mm: Simplify code in spl.c Date: Wed, 13 Jul 2022 11:52:24 +0200 Message-Id: <20220713095229.43274-14-frieder@fris.de> In-Reply-To: <20220713095229.43274-1-frieder@fris.de> References: <20220713095229.43274-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Frieder Schrempf Refactor the code a bit without any functional changes. Signed-off-by: Frieder Schrempf --- board/kontron/sl-mx8mm/spl.c | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/board/kontron/sl-mx8mm/spl.c b/board/kontron/sl-mx8mm/spl.c index 212d712de6f..28211ae78f3 100644 --- a/board/kontron/sl-mx8mm/spl.c +++ b/board/kontron/sl-mx8mm/spl.c @@ -109,41 +109,26 @@ static void spl_dram_init(void) size = 1; } - printf("Kontron SL i.MX8MM (N801X) module, %u GB RAM detected\n", size); + gd->ram_size = size; writel(size, M4_BOOTROM_BASE_ADDR); } -static int i2c_detect(u8 bus, u16 addr) -{ - struct udevice *udev; - int ret; - - /* - * Try to probe the touch controller to check if an LVDS panel is - * connected. - */ - ret = i2c_get_chip_for_busnum(bus, addr, 0, &udev); - if (ret == 0) - return 0; - - return 1; -} - int do_board_detect(void) { + gd->board_type = BOARD_TYPE_KTN_N801X; + printf("Kontron SL i.MX8MM (N801X) module, %u GB RAM detected\n", gd->ram_size); + /* * Check the I2C PMIC to detect the deprecated SoM with DA9063. */ imx_iomux_v3_setup_multiple_pads(i2c1_pads, ARRAY_SIZE(i2c1_pads)); - if (i2c_detect(0, 0x58) == 0) { + if (i2c_get_chip_for_busnum(0, 0x58, 0, &udev) == 0) { printf("### ATTENTION: DEPRECATED SOM REVISION (N8010 Rev0) DETECTED! ###\n"); printf("### THIS HW IS NOT SUPPORTED AND BOOTING WILL PROBABLY FAIL ###\n"); printf("### PLEASE UPGRADE TO LATEST MODULE ###\n"); } - gd->board_type = BOARD_TYPE_KTN_N801X; - return 0; } -- 2.37.0