public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Jaehoon Chung <jh80.chung@samsung.com>,
	Kirill Kapranov <kirill.kapranov@compulab.co.il>,
	Pantelis Antoniou <panto@antoniou-consulting.com>,
	Ye Li <ye.li@nxp.com>
Subject: Re: [PATCH] mmc: Do not send status of send_status is false
Date: Fri, 15 Jul 2022 10:49:47 +0200	[thread overview]
Message-ID: <20220715104947.43ffa225@dellmb> (raw)
In-Reply-To: <20220714235824.421904-1-marex@denx.de>

On Fri, 15 Jul 2022 01:58:24 +0200
Marek Vasut <marex@denx.de> wrote:

> Commit 44645f87de5 ("mmc: Fix mmc_switch excessive timeout") introduced
> a side effect where CMD13 SEND_STATUS is issued in case mmc_wait_dat0()
> does not return -ENOSYS and $send_status is not set. This happens on all
> hardware which does implement .mmc_wait_dat0 callback, e.g. i.MX8M .
> 
> This leads to lengthy timeout before booting OS in case of eMMC in one
> of the HS200/HS400 modes, since the card cannot respond to CMD13 while
> downgrading from HS200/HS400 to regular HS mode.
> 
> Fix this by adding the missing conditional.
> 
> Fixes: 44645f87de5 ("mmc: Fix mmc_switch excessive timeout")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Kirill Kapranov <kirill.kapranov@compulab.co.il>
> Cc: Marek Behún <marek.behun@nic.cz>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Ye Li <ye.li@nxp.com>

Does the lenghty timeout occur even on xenon with the patch
https://source.denx.de/u-boot/u-boot/-/commit/0f3466f52fbacce67e147b9234e6323edff26a6d
?

Marek

  reply	other threads:[~2022-07-15  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220726082840epcas1p495e05045d32a4f4e85642b4000703eff@epcas1p4.samsung.com>
2022-07-14 23:58 ` [PATCH] mmc: Do not send status of send_status is false Marek Vasut
2022-07-15  8:49   ` Marek Behún [this message]
2022-07-15 10:17     ` Marek Vasut
2022-07-26  8:28   ` Jaehoon Chung
2022-08-10 21:50   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220715104947.43ffa225@dellmb \
    --to=kabel@kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=kirill.kapranov@compulab.co.il \
    --cc=marex@denx.de \
    --cc=panto@antoniou-consulting.com \
    --cc=u-boot@lists.denx.de \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox