public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Kever Yang <kever.yang@rock-chips.com>
Subject: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper
Date: Fri, 15 Jul 2022 18:30:35 +0200	[thread overview]
Message-ID: <20220715163035.GF2143@begut> (raw)

Spi0 is not needed in SPL and SPL could be a little smaller without it,
but then the SF_DEFAULT_BOOT would have to be 0 to refer to spi1, and
that's confusing, because once U-Boot proper runs, it numbers the bus 1.

Add spi0 to the pre-reloc and spl trees so that the flash is always
connected to bus 1.

Changes since v1:
   - new patch in v2.

Signed-off-by: Xavier Drudis Ferran <xdrudis@tinet.cat>

Cc: Simon Glass <sjg@chromium.org>
Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Kever Yang <kever.yang@rock-chips.com>

---
 arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
index 4c2fe8f6bc..68b6b752d6 100644
--- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
@@ -16,6 +16,12 @@
 	regulator-init-microvolt = <950000>;
 };
 
+/* not needed, but nicer to keep SF_DEFAULT_BUS in SPL the same index as in U-Boot proper */
+&spi0 {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
 &spi1 {
 	status = "okay";
 	spi-max-frequency = <40000000>;
-- 
2.20.1


             reply	other threads:[~2022-07-15 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15 16:30 Xavier Drudis Ferran [this message]
2022-07-18  8:33 ` [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper Quentin Schulz
2022-07-18  8:39   ` Michal Suchánek
2022-07-18  9:09   ` Xavier Drudis Ferran
2022-07-18 11:00     ` Michal Suchánek
2022-07-18 13:01       ` Quentin Schulz
2022-07-18 14:06         ` Michal Suchánek
2022-08-27  3:51         ` Kever Yang
2022-07-18 13:14       ` Xavier Drudis Ferran
2022-07-18 14:09         ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220715163035.GF2143@begut \
    --to=xdrudis@tinet.cat \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox