From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80BD8C43334 for ; Sat, 16 Jul 2022 17:02:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D24581874; Sat, 16 Jul 2022 19:02:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 054B481877; Sat, 16 Jul 2022 19:02:07 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id CA21980112 for ; Sat, 16 Jul 2022 19:02:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71F201063; Sat, 16 Jul 2022 10:02:03 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E05083F70D; Sat, 16 Jul 2022 10:02:01 -0700 (PDT) Date: Sat, 16 Jul 2022 18:00:50 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Joe Hershberger , Ramon Fried Subject: Re: [PATCH 1/3] net: sun8i-emac: Downgrade printf during probe to debug Message-ID: <20220716180050.55be9701@slackpad.lan> In-Reply-To: <20220715052058.28405-2-samuel@sholland.org> References: <20220715052058.28405-1-samuel@sholland.org> <20220715052058.28405-2-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 15 Jul 2022 00:20:56 -0500 Samuel Holland wrote: > This just prints the PHY mode taken from the devicetree. It does not > need to be printed during every boot. That's true, but I think a more important reason is that it spoils the output, doesn't it? It reads: Net: phy interface9 eth0: ethernet@1c30000 at the moment, but I guess the intention was just: Net: eth0: ethernet@1c30000 So given that, and the fact that "interface9" is not really helpful, that looks alright to me. > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Thanks, Andre > --- > > drivers/net/sun8i_emac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c > index 2220f84b6978..a4b3492b7647 100644 > --- a/drivers/net/sun8i_emac.c > +++ b/drivers/net/sun8i_emac.c > @@ -857,7 +857,7 @@ static int sun8i_emac_eth_of_to_plat(struct udevice *dev) > priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1); > > pdata->phy_interface = dev_read_phy_mode(dev); > - printf("phy interface%d\n", pdata->phy_interface); > + debug("phy interface %d\n", pdata->phy_interface); > if (pdata->phy_interface == PHY_INTERFACE_MODE_NA) > return -EINVAL; >