From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0A5BC433EF for ; Mon, 18 Jul 2022 08:39:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B5D18401B; Mon, 18 Jul 2022 10:39:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="X+X72c7V"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BP4HJZ0k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E9828401E; Mon, 18 Jul 2022 10:39:16 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EA2A484012 for ; Mon, 18 Jul 2022 10:39:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=msuchanek@suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B76BB3733F; Mon, 18 Jul 2022 08:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658133553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+66X7Lcl+HLjsqIYNyMHCQNaRyt598jgarXY24SY1Y=; b=X+X72c7VUhoI1ybtw10d0jfa6wWKpRPddaIfSFVhXrq/5kU9GVPUgrvXN9kh5zzbfQl8uy ksJbZ3kQAkDKeDZAWo/TNNRYkJ1RfCOxPyVNEXNgfHtmb3L0NSrUJ62XlFTm70esy3d96d Rt0Z/ssZqOql1iQS1wA6JCbtjfb8hKU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658133553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+66X7Lcl+HLjsqIYNyMHCQNaRyt598jgarXY24SY1Y=; b=BP4HJZ0kv2HH9+D8bn4gAbDf7YUXvbv3i2xe685GgxxRqc/chJbQrpcuYRs8fNZhoCZ0fR shyJXZqeW0cok/BQ== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2332B2C141; Mon, 18 Jul 2022 08:39:13 +0000 (UTC) Date: Mon, 18 Jul 2022 10:39:11 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Quentin Schulz Cc: Xavier Drudis Ferran , u-boot@lists.denx.de, Simon Glass , Philipp Tomsich , Kever Yang Subject: Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper Message-ID: <20220718083911.GP17705@kitsune.suse.cz> References: <20220715163035.GF2143@begut> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz wrote: > Hi Xavier, > > On 7/15/22 18:30, Xavier Drudis Ferran wrote: > > Spi0 is not needed in SPL and SPL could be a little smaller without it, > > but then the SF_DEFAULT_BOOT would have to be 0 to refer to spi1, and > > that's confusing, because once U-Boot proper runs, it numbers the bus 1. > > > > Add spi0 to the pre-reloc and spl trees so that the flash is always > > connected to bus 1. > > > > Mmmm... Could we instead make U-Boot use the bus number from the alias in > the aliases DT node? I think the mmc subsystem does this already and it > would mean we don't need to enable unnecessary devices. Also, relying on It does not seem to work for mmc, though. I have mmc2 and mmc1 in SPL, and mmc1 and mmc0 in u-boot. There are actually 3 mmc interfaces using 2 drivers so the situations is .. complex. Thanks Michal