From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: Xavier Drudis Ferran <xdrudis@tinet.cat>,
u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper
Date: Mon, 18 Jul 2022 11:09:56 +0200 [thread overview]
Message-ID: <20220718090956.GA2796@begut> (raw)
In-Reply-To: <fd0d090d-59b1-3c29-c4b1-72d778bde9fd@theobroma-systems.com>
El Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz deia:
> Hi Xavier,
>
> On 7/15/22 18:30, Xavier Drudis Ferran wrote:
> > Spi0 is not needed in SPL and SPL could be a little smaller without it,
> > but then the SF_DEFAULT_BOOT would have to be 0 to refer to spi1, and
> > that's confusing, because once U-Boot proper runs, it numbers the bus 1.
> >
> > Add spi0 to the pre-reloc and spl trees so that the flash is always
> > connected to bus 1.
> >
>
> Mmmm... Could we instead make U-Boot use the bus number from the alias in
> the aliases DT node? I think the mmc subsystem does this already and it
> would mean we don't need to enable unnecessary devices. Also, relying on
> boot order for the bus number is brittle in Linux, I don't know about
> U-Boot, but if we can avoid this assumption, it'd be great :)
>
> See: https://source.denx.de/u-boot/u-boot/-/commit/2243d19e5618122d9d7aba23eb51f63f2719dba5
> for how to do it today?
>
Maybe I should just drop this patch and try to define
CONFIG_SPL_DM_SEQ_ALIAS in configs/rock-pi-4-rk3399 instead ?
Let me test this a little...
I have CONFIG_DM_SEQ_ALIAS=y but CONFIG_SPL_DM_SEQ_ALIAS unset.
>
> Your patch series got sent with each commit in their individual thread
I know. Sorry for the lapsus. I did it right in v1, wrong in v2, and will do right in v3.
next prev parent reply other threads:[~2022-07-18 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 16:30 [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper Xavier Drudis Ferran
2022-07-18 8:33 ` Quentin Schulz
2022-07-18 8:39 ` Michal Suchánek
2022-07-18 9:09 ` Xavier Drudis Ferran [this message]
2022-07-18 11:00 ` Michal Suchánek
2022-07-18 13:01 ` Quentin Schulz
2022-07-18 14:06 ` Michal Suchánek
2022-08-27 3:51 ` Kever Yang
2022-07-18 13:14 ` Xavier Drudis Ferran
2022-07-18 14:09 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718090956.GA2796@begut \
--to=xdrudis@tinet.cat \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox