From: Michael Trimarchi <michael@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: "Dario Binacchi" <dario@amarulasolutions.com>,
"Tommaso Merciai" <tommaso.merciai@amarulasolutions.com>,
"Zhengxun Li" <zhengxunli@mxic.com.tw>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Wolfgang Denk" <wd@denx.de>, "Marek Behún" <marek.behun@nic.cz>,
"Pali Rohár" <pali@kernel.org>,
"Kory Maincent" <kory.maincent@bootlin.com>,
"Simon Glass" <sjg@chromium.org>
Subject: [PATCH V2 11/13] mtd: nand: Move Macronix specific initialization in nand_macronix.c
Date: Tue, 19 Jul 2022 22:22:01 +0200 [thread overview]
Message-ID: <20220719202213.1753259-12-michael@amarulasolutions.com> (raw)
In-Reply-To: <20220719202213.1753259-1-michael@amarulasolutions.com>
Upstream linux commit 3b5206f4be
Move Macronix specific initialization logic into nand_macronix.c. This
is part of the "separate vendor specific code from core" cleanup
process.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
V1->V2:
- use short-commit form
- remove linux info. Uboot seems that backport without add this
extra information
- adjust the include file in nand_macronix
---
drivers/mtd/nand/raw/Makefile | 4 +++-
drivers/mtd/nand/raw/nand_base.c | 11 ----------
drivers/mtd/nand/raw/nand_ids.c | 2 +-
drivers/mtd/nand/raw/nand_macronix.c | 30 ++++++++++++++++++++++++++++
include/linux/mtd/rawnand.h | 1 +
5 files changed, 35 insertions(+), 13 deletions(-)
create mode 100644 drivers/mtd/nand/raw/nand_macronix.c
diff --git a/drivers/mtd/nand/raw/Makefile b/drivers/mtd/nand/raw/Makefile
index e1d511c12c..c8317a1078 100644
--- a/drivers/mtd/nand/raw/Makefile
+++ b/drivers/mtd/nand/raw/Makefile
@@ -14,7 +14,8 @@ obj-$(CONFIG_SPL_NAND_DENALI) += denali_spl.o
obj-$(CONFIG_SPL_NAND_SIMPLE) += nand_spl_simple.o
obj-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o
obj-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o
-obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_amd.o nand_hynix.o nand_micron.o \
+obj-$(CONFIG_SPL_NAND_BASE) += nand_base.o nand_amd.o nand_hynix.o \
+ nand_macronix.o nand_micron.o \
nand_samsung.o nand_toshiba.o
obj-$(CONFIG_SPL_NAND_IDENT) += nand_ids.o nand_timings.o
obj-$(CONFIG_TPL_NAND_INIT) += nand.o
@@ -34,6 +35,7 @@ obj-y += nand_ecc.o
obj-y += nand_base.o
obj-y += nand_amd.o
obj-y += nand_hynix.o
+obj-y += nand_macronix.o
obj-y += nand_micron.o
obj-y += nand_samsung.o
obj-y += nand_toshiba.o
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index f79e57b9fb..a38cc4d135 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -4218,22 +4218,11 @@ static void nand_decode_id(struct nand_chip *chip,
static void nand_decode_bbm_options(struct mtd_info *mtd,
struct nand_chip *chip)
{
- int maf_id = chip->id.data[0];
-
/* Set the bad block position */
if (mtd->writesize > 512 || (chip->options & NAND_BUSWIDTH_16))
chip->badblockpos = NAND_LARGE_BADBLOCK_POS;
else
chip->badblockpos = NAND_SMALL_BADBLOCK_POS;
-
- /*
- * Bad block marker is stored in the last page of each block on Samsung
- * and Hynix MLC devices; stored in first two pages of each block on
- * Micron devices with 2KiB pages and on SLC Samsung, Hynix, Toshiba,
- * AMD/Spansion, and Macronix. All others scan only the first page.
- */
- if (nand_is_slc(chip) && maf_id == NAND_MFR_MACRONIX)
- chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;
}
static inline bool is_full_id_nand(struct nand_flash_dev *type)
diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
index c78f2e0880..7602dd30f1 100644
--- a/drivers/mtd/nand/raw/nand_ids.c
+++ b/drivers/mtd/nand/raw/nand_ids.c
@@ -197,7 +197,7 @@ struct nand_manufacturers nand_manuf_ids[] = {
{NAND_MFR_HYNIX, "Hynix", &hynix_nand_manuf_ops},
{NAND_MFR_MICRON, "Micron", µn_nand_manuf_ops},
{NAND_MFR_AMD, "AMD/Spansion", &amd_nand_manuf_ops},
- {NAND_MFR_MACRONIX, "Macronix"},
+ {NAND_MFR_MACRONIX, "Macronix", ¯onix_nand_manuf_ops},
{NAND_MFR_EON, "Eon"},
{NAND_MFR_SANDISK, "SanDisk"},
{NAND_MFR_INTEL, "Intel"},
diff --git a/drivers/mtd/nand/raw/nand_macronix.c b/drivers/mtd/nand/raw/nand_macronix.c
new file mode 100644
index 0000000000..d290ff2a6d
--- /dev/null
+++ b/drivers/mtd/nand/raw/nand_macronix.c
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2017 Free Electrons
+ * Copyright (C) 2017 NextThing Co
+ *
+ * Author: Boris Brezillon <boris.brezillon@free-electrons.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mtd/rawnand.h>
+
+static int macronix_nand_init(struct nand_chip *chip)
+{
+ if (nand_is_slc(chip))
+ chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;
+
+ return 0;
+}
+
+const struct nand_manufacturer_ops macronix_nand_manuf_ops = {
+ .init = macronix_nand_init,
+};
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index bb1a359a9c..aa45558b3d 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -1143,6 +1143,7 @@ extern const struct nand_manufacturer_ops samsung_nand_manuf_ops;
extern const struct nand_manufacturer_ops hynix_nand_manuf_ops;
extern const struct nand_manufacturer_ops micron_nand_manuf_ops;
extern const struct nand_manufacturer_ops amd_nand_manuf_ops;
+extern const struct nand_manufacturer_ops macronix_nand_manuf_ops;
int nand_default_bbt(struct mtd_info *mtd);
int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs);
--
2.34.1
next prev parent reply other threads:[~2022-07-19 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 20:21 [PATCH V2 00/13] Port manufacturer specific initialization Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 01/13] mtd: nand: Get rid of busw parameter Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 02/13] mtd: nand: Store nand ID in struct nand_chip Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 03/13] mtd: nand: Add manufacturer specific initialization/detection steps Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 04/13] mtd: nand: Get rid of mtd variable in function calls Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 05/13] mtd: nand: Export symbol nand_decode_ext_id Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 06/13] mtd: nand: Move Samsung specific init/detection logic in nand_samsung.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 07/13] mtd: nand: Move Hynix specific init/detection logic in nand_hynix.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 08/13] mtd: nand: Move Toshiba specific init/detection logic in nand_toshiba.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 09/13] mtd: nand: Move Micron specific init logic in nand_micron.c Michael Trimarchi
2022-07-19 20:22 ` [PATCH V2 10/13] mtd: nand: Move AMD/Spansion specific init/detection logic in nand_amd.c Michael Trimarchi
2022-07-19 20:22 ` Michael Trimarchi [this message]
2022-07-19 20:22 ` [PATCH V2 12/13] mtd: nand: toshiba: Retrieve ECC requirements from extended ID Michael Trimarchi
2022-07-19 20:22 ` [PATCH V2 13/13] mtd: decommission the NAND museum Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719202213.1753259-12-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=dario@amarulasolutions.com \
--cc=kory.maincent@bootlin.com \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=sjg@chromium.org \
--cc=tommaso.merciai@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox