From: Michael Trimarchi <michael@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Dario Binacchi <dario@amarulasolutions.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Subject: [PATCH V2 12/13] mtd: nand: toshiba: Retrieve ECC requirements from extended ID
Date: Tue, 19 Jul 2022 22:22:02 +0200 [thread overview]
Message-ID: <20220719202213.1753259-13-michael@amarulasolutions.com> (raw)
In-Reply-To: <20220719202213.1753259-1-michael@amarulasolutions.com>
Upstream linux commit fb3bff5b40
This patch enables support to read the ECC strength and size from the
NAND flash using Toshiba Memory SLC NAND extended-ID. This patch is
based on the information of the 6th ID byte of the Toshiba Memory SLC
NAND.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
V1->V2:
- use short-commit form
- remove linux info. Uboot seems that backport without add this
extra information
---
drivers/mtd/nand/raw/nand_toshiba.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/mtd/nand/raw/nand_toshiba.c b/drivers/mtd/nand/raw/nand_toshiba.c
index 4328e566b0..1adce3ebbd 100644
--- a/drivers/mtd/nand/raw/nand_toshiba.c
+++ b/drivers/mtd/nand/raw/nand_toshiba.c
@@ -36,6 +36,32 @@ static void toshiba_nand_decode_id(struct nand_chip *chip)
(chip->id.data[5] & 0x7) == 0x6 /* 24nm */ &&
!(chip->id.data[4] & 0x80) /* !BENAND */)
mtd->oobsize = 32 * mtd->writesize >> 9;
+
+ /*
+ * Extract ECC requirements from 6th id byte.
+ * For Toshiba SLC, ecc requrements are as follows:
+ * - 43nm: 1 bit ECC for each 512Byte is required.
+ * - 32nm: 4 bit ECC for each 512Byte is required.
+ * - 24nm: 8 bit ECC for each 512Byte is required.
+ */
+ if (chip->id.len >= 6 && nand_is_slc(chip)) {
+ chip->ecc_step_ds = 512;
+ switch (chip->id.data[5] & 0x7) {
+ case 0x4:
+ chip->ecc_strength_ds = 1;
+ break;
+ case 0x5:
+ chip->ecc_strength_ds = 4;
+ break;
+ case 0x6:
+ chip->ecc_strength_ds = 8;
+ break;
+ default:
+ WARN(1, "Could not get ECC info");
+ chip->ecc_step_ds = 0;
+ break;
+ }
+ }
}
static int toshiba_nand_init(struct nand_chip *chip)
--
2.34.1
next prev parent reply other threads:[~2022-07-19 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 20:21 [PATCH V2 00/13] Port manufacturer specific initialization Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 01/13] mtd: nand: Get rid of busw parameter Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 02/13] mtd: nand: Store nand ID in struct nand_chip Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 03/13] mtd: nand: Add manufacturer specific initialization/detection steps Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 04/13] mtd: nand: Get rid of mtd variable in function calls Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 05/13] mtd: nand: Export symbol nand_decode_ext_id Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 06/13] mtd: nand: Move Samsung specific init/detection logic in nand_samsung.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 07/13] mtd: nand: Move Hynix specific init/detection logic in nand_hynix.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 08/13] mtd: nand: Move Toshiba specific init/detection logic in nand_toshiba.c Michael Trimarchi
2022-07-19 20:21 ` [PATCH V2 09/13] mtd: nand: Move Micron specific init logic in nand_micron.c Michael Trimarchi
2022-07-19 20:22 ` [PATCH V2 10/13] mtd: nand: Move AMD/Spansion specific init/detection logic in nand_amd.c Michael Trimarchi
2022-07-19 20:22 ` [PATCH V2 11/13] mtd: nand: Move Macronix specific initialization in nand_macronix.c Michael Trimarchi
2022-07-19 20:22 ` Michael Trimarchi [this message]
2022-07-19 20:22 ` [PATCH V2 13/13] mtd: decommission the NAND museum Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719202213.1753259-13-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=dario@amarulasolutions.com \
--cc=tommaso.merciai@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox