From: "Pali Rohár" <pali@kernel.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: u-boot@lists.denx.de, "Stefan Roese" <sr@denx.de>,
"Simon Glass" <sjg@chromium.org>,
"Chris Packham" <judge.packham@gmail.com>,
"Marek Behún" <marek.behun@nic.cz>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Samuel Holland" <samuel@sholland.org>
Subject: Re: [PATCH 2/2] tools: kwboot: use pkg-config to get -ltinfo
Date: Wed, 20 Jul 2022 09:05:04 +0200 [thread overview]
Message-ID: <20220720070504.elrtiddzcy7bqiv5@pali> (raw)
In-Reply-To: <CAEyMn7a0-S0zBDh1SxMaq6e-vn7rU3R-OhGPwQ4i4RR_WupVyw@mail.gmail.com>
On Wednesday 20 July 2022 08:06:28 Heiko Thiery wrote:
> Hi,
>
>
> Am Di., 19. Juli 2022 um 21:20 Uhr schrieb Pali Rohár <pali@kernel.org>:
> >
> > On Tuesday 19 July 2022 20:38:39 Heiko Thiery wrote:
> > > Instead of hardcoding -ltinfo as the flags needed to build
> > > kwboot, use pkg-config when available.
> > >
> > > We gracefully fallback on the previous behavior of hardcoding -ltinfo
> > > if pkg-config is not available or fails with an error.
> > >
> > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> >
> > So... in current form this patch is OK.
>
> I already sent a v2 that introduced the cflags. I will send a v3 that
> removes adding this again. Ok?
Ou, sorry for that :-(
Anyway, details about this issue are described here:
https://source.denx.de/u-boot/u-boot/-/blob/master/tools/termios_linux.h
https://source.denx.de/u-boot/u-boot/-/commit/e8d26e8276358fcd1c2fe28293d3b4c82a735731
> > Reviewed-by: Pali Rohár <pali@kernel.org>
> >
> > > ---
> > > tools/Makefile | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 9f6b282ad8..45195a8ce7 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -198,7 +198,9 @@ hostprogs-$(CONFIG_EXYNOS5420) += mkexynosspl
> > > HOSTCFLAGS_mkexynosspl.o := -pedantic
> > >
> > > HOSTCFLAGS_kwboot.o += -pthread
> > > -HOSTLDLIBS_kwboot += -pthread -ltinfo
> > > +HOSTLDLIBS_kwboot += -pthread
> > > +HOSTLDLIBS_kwboot += \
> > > + $(shell pkg-config --libs tinfo 2> /dev/null || echo "-ltinfo")
> > >
> > > ifdtool-objs := $(LIBFDT_OBJS) ifdtool.o
> > > hostprogs-$(CONFIG_X86) += ifdtool
> > > --
> > > 2.30.2
> > >
next prev parent reply other threads:[~2022-07-20 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 18:38 [PATCH 1/2] tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls Heiko Thiery
2022-07-19 18:38 ` [PATCH 2/2] tools: kwboot: use pkg-config to get -ltinfo Heiko Thiery
2022-07-19 18:52 ` Pali Rohár
2022-07-19 19:11 ` Heiko Thiery
2022-07-19 19:18 ` Pali Rohár
2022-07-19 19:20 ` Pali Rohár
2022-07-20 6:06 ` Heiko Thiery
2022-07-20 7:05 ` Pali Rohár [this message]
2022-07-19 18:51 ` [PATCH 1/2] tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls Pali Rohár
2022-07-19 19:11 ` Heiko Thiery
2022-07-19 18:59 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720070504.elrtiddzcy7bqiv5@pali \
--to=pali@kernel.org \
--cc=heiko.thiery@gmail.com \
--cc=judge.packham@gmail.com \
--cc=marek.behun@nic.cz \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox