public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: u-boot@lists.denx.de
Cc: "Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>,
	"Simon Glass" <sjg@chromium.org>,
	"Chris Packham" <judge.packham@gmail.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Heiko Thiery" <heiko.thiery@gmail.com>
Subject: [PATCH v3 2/2] tools: kwboot: use pkg-config to get -ltinfo
Date: Wed, 20 Jul 2022 12:31:35 +0200	[thread overview]
Message-ID: <20220720103133.601566-2-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20220720103133.601566-1-heiko.thiery@gmail.com>

Instead of hardcoding -ltinfo as the flags needed to build
kwboot, use pkg-config when available.

We gracefully fallback on the previous behavior of hardcoding -ltinfo
if pkg-config is not available or fails with an error.

Reviewed-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
v3:
 - remove cflags detection again
 - added reviewed-by

v2:
 - also add cflags detection via pkg-config (Thanks Pali)

 tools/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/Makefile b/tools/Makefile
index aab06aec93..005e7362a3 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -198,7 +198,9 @@ hostprogs-$(CONFIG_EXYNOS5420) += mkexynosspl
 HOSTCFLAGS_mkexynosspl.o := -pedantic
 
 HOSTCFLAGS_kwboot.o += -pthread
-HOSTLDLIBS_kwboot += -pthread -ltinfo
+HOSTLDLIBS_kwboot += -pthread
+HOSTLDLIBS_kwboot += \
+	$(shell pkg-config --libs tinfo 2> /dev/null || echo "-ltinfo")
 
 ifdtool-objs := $(LIBFDT_OBJS) ifdtool.o
 hostprogs-$(CONFIG_X86) += ifdtool
-- 
2.30.2


  reply	other threads:[~2022-07-20 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 10:31 [PATCH v3 1/2] tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls Heiko Thiery
2022-07-20 10:31 ` Heiko Thiery [this message]
2022-08-04 20:53   ` [PATCH v3 2/2] tools: kwboot: use pkg-config to get -ltinfo Tom Rini
2022-07-20 10:55 ` [PATCH v3 1/2] tools: mkeficapsule: use pkg-config to get -luuid and -lgnutls AKASHI Takahiro
2022-08-04 20:53 ` Tom Rini
2022-08-06  6:12   ` AKASHI Takahiro
2022-08-06 11:24     ` Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720103133.601566-2-heiko.thiery@gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=judge.packham@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=samuel@sholland.org \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox