From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A93C433EF for ; Fri, 22 Jul 2022 20:13:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 69D2D83AC3; Fri, 22 Jul 2022 22:12:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WGa6OD/F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 35C0383AC3; Fri, 22 Jul 2022 22:12:57 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9DDF68032B for ; Fri, 22 Jul 2022 22:12:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id b21so4285327qte.12 for ; Fri, 22 Jul 2022 13:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WQRurVcdkHQBKVjCGyZ8PZtIguo/A5FHqOb1NsCj/0g=; b=WGa6OD/FGK1jNNiIudHwO4+ghDje9h2rFb5nbIPipRwhv6762OwmEJWLVKnKk3o8HL o2a4x3WZwmKUEsPzY4IHzLx3f/st56JkFSzUeLr/3VTtwy2vLhcpU7TNp765hwD5Mcrv 3HSkKuRc1681pTTS106tSn48P4sJql4y3SNgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WQRurVcdkHQBKVjCGyZ8PZtIguo/A5FHqOb1NsCj/0g=; b=hpJ+UYA+14Dp4J1foW1/8B2n9fhnJg9EXf+0QLnq6FeGQ4H3DMvSRBEXj7aViatncG NxljJHASfeZ/X2RZEneGxHakq5Fikl7J1Kq6LSYl8XphQX3vNOUIFeE+nn8m+HYmBwpl jrbbM8yiGOmLVpHkI2D5lhheN5Rn5y+S5wtJv4OLlq+xsw5NcLwd0RhxOqEw3+BxKaMU BWv6Or28GMIFdSfLfVsfzCc/Tev8tiLxOYhoHnV0KKj/ekJC4ADQW1PHVSCyC0g32QDg dzD7rrX8WR/Xd9bgbGzgMES7Wj/IDFXTHs+gOGqlqoLmbXAtFTKkANYElt7YmKWN8hxc 4MLg== X-Gm-Message-State: AJIora/REX4hFVnCwP2g/t7Ry0etxxiPzFgEeM3IkJvXtcpEosx5sCqf oxukxDfGsdBjgc3mqjkidgn/RGyYXTE4gg== X-Google-Smtp-Source: AGRyM1sLyk7Qi+0LMZBO30bMV5Hpsq/fNYXS7WiOY10K/P9hXoqQRECE4zaGmecbHpsy3u+R0cT4nw== X-Received: by 2002:ac8:7f52:0:b0:31f:27d7:d953 with SMTP id g18-20020ac87f52000000b0031f27d7d953mr1634100qtk.553.1658520771257; Fri, 22 Jul 2022 13:12:51 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id h11-20020a05620a400b00b006b60c965024sm4188125qko.113.2022.07.22.13.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 13:12:50 -0700 (PDT) Date: Fri, 22 Jul 2022 16:12:48 -0400 From: Tom Rini To: Tim Harvey Cc: u-boot Subject: Re: [PATCH 01/17] Convert CONFIG_FSL_FIXED_MMC_LOCATION et al to Kconfig Message-ID: <20220722201248.GC1146598@bill-the-cat> References: <20220620120758.765049-1-trini@konsulko.com> <20220722190639.GA1146598@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yLYDKuIFMNdqVlI2" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --yLYDKuIFMNdqVlI2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 22, 2022 at 01:05:38PM -0700, Tim Harvey wrote: > On Fri, Jul 22, 2022 at 12:06 PM Tom Rini wrote: > > > > On Fri, Jul 22, 2022 at 11:01:52AM -0700, Tim Harvey wrote: > > > On Mon, Jun 20, 2022 at 5:08 AM Tom Rini wrote: > > > > > > > > This converts the following to Kconfig: > > > > CONFIG_FSL_FIXED_MMC_LOCATION > > > > CONFIG_ESDHC_HC_BLK_ADDR > > > > > > > > Signed-off-by: Tom Rini > > [snip] > > > Tom, > > > > > > I'm not sure this patch had the intended results. I just noticed that > > > default bootcmd was changed due to this for the the imx8m*venice > > > boards I maintain. > > > > > > How did you go about generating this? In my case > > > CONFIG_USE_BOOTCOMMAND is not set and prior to this patch was getting > > > defaulted in include/config_distro_bootcmd.h but now that is removed > > > and its getting set in tools/env/fw_env_private.h to something > > > different. > > > > > > To fix this, I'll have to submit a patch that does the following for > > > configs/imx8m*_venice_defconfig > > > +CONFIG_USE_BOOTCOMMAND=3Dy > > > +CONFIG_BOOTCOMMAND=3D"run distro_bootcmd" > > > > > > I figured it was worth mentioning and asking for others that run into= this. > > > > It's this commit, specifically? Looking at u-boot-initial-env (and > > disabling LTO for the moment), I don't see bootcmd set before nor after. > > I could see this being a merge related problem or similar from > > 970bf8603b877e2b66170290f751f9c23c120838 where I finished moving > > everyone that was in-tree at the time that should have been setting > > CONFIG_USE_BOOTCOMMAND and then CONFIG_BOOTCOMMAND (if not using the > > default) leading to this kind of problem. > > >=20 > Tom, >=20 > I apologize... not sure how I ended up replying to the wrong patch. >=20 > Indeed it is commit 970bf8603b87 ("Convert CONFIG_USE_BOOTCOMMAND et > al to Kconfig") that I was referring to. >=20 > It looks like any board that specifically did not define > CONFIG_USE_BOOTCOMMAND was likely affected and if I simply remove '# > CONFIG_USE_BOOTCOMMAND is not set' from my defconfigs it fixes it. >=20 > This is what I was going to submit but if the above assumption is > correct there would be a lot of other boards affected. >=20 > imx8m*_venice_defconfig: fix default bootcmd >=20 > commit 970bf8603b87 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig= ") > had an unintended side effect of resulting in a bootcmd env var change > for boards like venice that did not have CONFIG_USE_BOOTCOMMAND defin= ed > and relied on it being defaulted in include/config_distro_bootcmd.h. > Following that patch it instead got defaulted in tools/env/fw_env_pri= vate.h >=20 > Fix this by enabling CONFIG_USE_BOOTCOMMAND for venice. >=20 > Fixes: commit 970bf8603b87 ("Convert CONFIG_USE_BOOTCOMMAND et al to = Kconfig > ") > Signed-off-by: Tim Harvey >=20 OK, yeah, makes more sense. I'm not quite sure how I missed this platform in the migration but apparently I did. A patch to fix up other platforms you can see were also broken would be appreciated, thanks! --=20 Tom --yLYDKuIFMNdqVlI2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLbBLwACgkQFHw5/5Y0 tyxf1QwAquuvJhWYmDThflgAuw8q0NkAyCH4yKtLciKWOWTNIGnVOBFJ0fiZUnOS UGaj3HAvClqy95BsJuowx9a0PspwqLf6PsqpYs+b3TCRFE3fE7zkLCV3PxsLUKVG 8Lt31grOfzklQS1iXbU8K/tPyikChfEWxWQmGv34ZEjB2Kz78kswdxolIQjeSCrU xkTwQIErMuRrgaGBNp2eV/woXRlsjTwUm8GFCaoknrH1CpwLsy/rcEMSGJeWQftw yvFvb9nRNSNO/L+K/+JA1tYs1+E2+2R+8cHnHGbf6uM5zEGcTdixQHeDxtJlwgOc nEkIm3vyTBINEtnHSm/1XAVWF5Vn8eq97UK7HRkpReQIY4ecAno1BCcsDrxHTVI3 sYq0Et8n2uzhIqNR/8BtmctbvZdeYZ5BDfuSsxyyOUEg44fAnzTbYOXeR5tOuaLM rdA+9/2rQnN40vt2JFWkQdpHqqy022N1IQww1lMbR8XXz69vML90TjrMTtpSjc1v h79KoF6k =UcwA -----END PGP SIGNATURE----- --yLYDKuIFMNdqVlI2--