From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7B35C433EF for ; Sun, 24 Jul 2022 11:47:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9BE6783EF2; Sun, 24 Jul 2022 13:47:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A658084003; Sun, 24 Jul 2022 09:46:33 +0200 (CEST) Received: from mx1.tinet.cat (mx1.tinet.org [195.77.216.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4535383F97 for ; Sun, 24 Jul 2022 09:46:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1658648788-163e7b333be0100001-4l7tJC Received: from smtp01.tinet.cat (smtp01.tinet.org [195.77.216.131]) by mx1.tinet.cat with ESMTP id N2PMGuUm16fus7fm; Sun, 24 Jul 2022 09:46:28 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp01.tinet.org[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from begut (99.red-79-152-185.dynamicip.rima-tde.net [79.152.185.99]) by smtp01.tinet.cat (Postfix) with ESMTPSA id C5580605D0A1; Sun, 24 Jul 2022 09:46:27 +0200 (CEST) Date: Sun, 24 Jul 2022 09:46:15 +0200 From: Xavier Drudis Ferran To: Quentin Schulz Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, jagan@amarulasolutions.com, alpernebiyasak@gmail.com, andy.yan@rock-chips.com, hl@rock-chips.com, chenjh@rock-chips.com, manivannan.sadhasivam@linaro.org, nick@khadas.com, klaus.goger@theobroma-systems.com, jernej.skrabec@gmail.com, jbx6244@gmail.com, deepakdas.linux@gmail.com, linux@alxd.me, mail@david-bauer.net, peterwillcn@gmail.com, heiko@sntech.de, w.egorov@phytec.de, pbrobinson@gmail.com, sunil@amarulasolutions.com, ldevulder@suse.com, akash@openedev.com, banglang.huang@foxmail.com, matwey.kornilov@gmail.com, michael@amarulasolutions.com, xypron.glpk@gmx.de, u-boot@lists.denx.de, Quentin Schulz Subject: Re: [SPAM] [PATCH v2 0/7] migrate u-boot-rockchip.bin to binman and generate an image for SPI Message-ID: <20220724074615.GA2110@begut> X-ASG-Orig-Subj: Re: [SPAM] [PATCH v2 0/7] migrate u-boot-rockchip.bin to binman and generate an image for SPI References: <20220722113505.3875669-1-foss+uboot@0leil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220722113505.3875669-1-foss+uboot@0leil.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Barracuda-Connect: smtp01.tinet.org[195.77.216.131] X-Barracuda-Start-Time: 1658648788 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1646 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: SPAM GLOBAL 1.0000 1.0000 4.3430 X-Barracuda-Spam-Score: 4.34 X-Barracuda-Spam-Status: No, SCORE=4.34 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.99594 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Mailman-Approved-At: Sun, 24 Jul 2022 13:47:39 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean El Fri, Jul 22, 2022 at 01:34:58PM +0200, Quentin Schulz deia: > From: Quentin Schulz > > This migrates the generation of u-boot-rockchip.bin from Makefile to binman > completely. There is therefore no idbloader.img anymore as it is created on > the fly by binman. > Thanks a lot. I've tested this series and it worked for me and my Rock Pi 4B. That's a similar board, RK3399 too. Maybe it needs more refinements for other rockchip boards. I haven't spent a lot of time testing yet, and I've tested it with two or three dozen patches on top of master, so not quite the real thing. One thing that comes to mind is that master has CONFIG_ENV_IS_IN_MMC=y and I have it disabled and CONFIG_ENV_IS_NOWHERE=y. So maybe we should check in dtsi whether we need binman to call mkenvimage (and scripts/get_default_envs.sh or from what source?) and put the output at CONFIG_ENV_OFFSET=0x3F8000 for the SD image. Or maybe we should just disable CONFIG_ENV_IS_IN_MMC in the board ? (I think it conflicts with trust settings anyway). Or maybe just leave as it is and let env load non-fatally fail unless the user provides their own custom environment ? Now that we have Quentin's patches maybe we can remove the Makefile warning about CONFIG_USE_SPL_FIT_GENERATOR and move the task that arch/arm/mach-rockchip/make_fit_atf.py is doing to binman. But I don't seem to find any dts using "split-elf" I even wonder, am I right to assume make_fit_atf.py is deprecated and split-elf prefered ? Because split-elf seems to be unused and make_fit_atf.py seems to be default ???