From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3186C43334 for ; Mon, 25 Jul 2022 16:43:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 305E4844E8; Mon, 25 Jul 2022 18:40:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1658767239; bh=yIGp5OiWa/w03sVefLq+XeyMG8wwUn6mIGNFEtVF1xE=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=BC0PEwug0DRJfe7NC4DNCyvi+TCo3Ue+0pWBbWe/pyZFPOlrTZXQL8DlIaSQHu7Cz dI5gE9VCB+zRasxcq+iIXBy8knHHE9SZQyRU+EpnXyPQgZMyS/4347s+7H+VqDTw2m MlhWAb2mM2C4zyRRT2TLW2e5S+f01ySGo1GzDzNZbh7fUxwPjNtxcXiA1UXir5BmlP HC0xaChJxaCcJHHyGumOtiuo56sbQ+7wTTJQe/ygQoRY5ZHTpA0H8cvEUfJbQwT/sV CAEQtri2fgq+JInNhEmMxAn6SikMqPhHkmkN5NzeFGUS1ys8ccrPtv7qZ9CLU0WApR aco+js4H9wsvw== Received: by phobos.denx.de (Postfix, from userid 109) id 9344F844C9; Mon, 25 Jul 2022 18:40:33 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6E57F844B6 for ; Mon, 25 Jul 2022 18:40:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Ls5Pq1bHBz1s7sy; Mon, 25 Jul 2022 18:40:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Ls5Pq1RzGz1qqkH; Mon, 25 Jul 2022 18:40:31 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id O1KPqJfmJ5Ki; Mon, 25 Jul 2022 18:40:30 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 25 Jul 2022 18:40:30 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 1645316 X-Patchwork-Delegate: sbabic@denx.de To: Rasmus Villemoes ,u-boot@lists.denx.de Subject: [PATCH v2 3/6] imx8: add rom api wrappers In-reply-to: <20220620085322.1108802-4-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20220725164033.9344F844C9@phobos.denx.de> Date: Mon, 25 Jul 2022 18:40:31 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > The ROM API is thoroughly undocumented, but apparently passing the xor > of the real arguments as an extra argument is required [1]. Also, we > need to do the "save gd/restore gd" dance. These are both error-prone, > and lead to a lot of code duplication. > Since both imx8m[np] and imx8ulp SOCs have this, add a separate > translation unit which is included precisely when the new > CONFIG_IMX8_ROMAPI symbol is set, which provide convenience wrappers > that take care of computing the xor value as well as doing the gd > dance, and that thus have a more intuitive API. Subsequent patches > will make use of these to reduce boilerplate. > [1] One wonders, for example, if the check is only applied to the > lower 32 bits, or if we're implicitly relying on all 64-bit pointer > values we're passing effectively have 0 in the upper 32 bits. > Reviewed-by: Peng Fan > Signed-off-by: Rasmus Villemoes Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================