Re: Replace make-fit-atf.py with binman. Was: migrate u-boot-rockchip.bin to binman and generate an image for SPI

Jerome Forissier
2022-07-26T19:15:20Z

On 7/26/22 21:08, Xavier Drudis Ferran wrote:
> El Tue, Jul 26, 2022 at 11:08:21AM +0200, Quentin Schulz deia:
>>
>> You could also have a fit,align = <8>; property instead of hardcoding it.
>
> I'm not sure the fit entry in binman heeds this property, may have
> overlooked something. I'd have to try it.
>
>> The issue is that this flag seems to be added only for u-boot.itb and
>> fit-dtb.blob. I assume there are usecases outside of those two binaries
>> where the user does not want the fit header to be aligned (or don't need
>> it).
>
> The commit message said that the device tree spec requires 4 or 8 byte
> alignment, so maybe all fits want it because all fits are device trees
> ? Not sure.
>
>>>> + configurations {
>>>> + default = "@config_DEFAULT-SEQ";
>>>> +
>>>> + @config_SEQ {
>>>> + description = "NAME.dtb";
>>>> + fdt = "fdt_SEQ";
>>>> + firmware = "atf_1";
>>>> + loadables = "uboot","atf_2","atf_3";
>>
>> This section will need some more love with some ifdef for ATF_SPL and TEE.
>>
>
> I'm sending a patch below that adds a couple of configuration properties to
> binman so that split-elf can fill the properties. How many segments are
> in bl31.elf or optee is not something that we have in CONFIGs, I think,
> so it may be difficult to catch all cases with ifdefs.

Careful with OP-TEE: tee.elf must NOT be used, please see commit
348310233dac ("mach-rockchip: make_fit_atf.py: support OP-TEE tee.bin v1
format").

--
Jerome