Re: Replace make-fit-atf.py with binman. Was: migrate u-boot-rockchip.bin to binman and generate an image for SPI

Simon Glass
2022-07-26T19:59:08Z

Hi Quentin,

On Tue, 26 Jul 2022 at 03:08, Quentin Schulz
<quentin.schulz@theobroma-systems.com> wrote:
>
> Hi Xavier,
>
> On 7/25/22 19:33, Xavier Drudis Ferran wrote:
> > El Mon, Jul 25, 2022 at 07:29:53PM +0200, Xavier Drudis Ferran deia:
> >>
> >> I copy here the rockchip-u-boot.dtsi file and then 2 patches on top of yours.
> >>
> >
> > Sorry I copied a dirty version that din't work. The patches were correct, the dtsi wasn't.
> >

[..]

>
> >> + };
> >> + };
> >> + };
> >> + };
> >> simple-bin {
> >> filename = "u-boot-rockchip.bin";
> >> pad-byte = <0xff>;
> >> @@ -62,6 +131,7 @@
> >> #ifdef CONFIG_ARM64
> >> blob {
> >> filename = "u-boot.itb";
> >> +
>
> This is unfortunately not possible since binman parallelizes the build
> of images in the binman DT node. This means there is no guarantee the
> u-boot.itb file is generated before this section is worked on by binman.
> Or maybe I misunderstood the docs.

You are correct, but this is something that has bothered me.

At the moment we handle this by embedding the definition for one file
into the one that uses it. This is on the theory that there is no need
to actually write the embedded file, since it is a temporary file. In
fact binman does generate temporary files though.

Is that good enough? If not I'd like to understand the need better,
before we make any changes.

>
> But good progress, I guess this phandle thing "just" needs to be fixed
> to have something nice (both for this patch series and mine).
>
> Cheers,
> Quentin
[..]

Regards,
Simon