public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>
Cc: u-boot@lists.denx.de
Subject: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method
Date: Tue,  2 Aug 2022 11:55:19 +0200	[thread overview]
Message-ID: <20220802095519.17352-1-pali@kernel.org> (raw)

BootROM boot method should always work so always add it as fallback method
to spl_boot_list. In case U-Boot SPI driver fails it is better to try using
BootROM than hanging as by default only one boot method is specified.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/mach-mvebu/spl.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 13c99913c380..bfcba2e73bab 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -271,6 +271,13 @@ u32 spl_boot_device(void)
 	}
 }
 
+void board_boot_order(u32 *spl_boot_list)
+{
+	spl_boot_list[0] = spl_boot_device();
+	if (spl_boot_list[0] != BOOT_DEVICE_BOOTROM)
+		spl_boot_list[1] = BOOT_DEVICE_BOOTROM;
+}
+
 #else
 
 u32 spl_boot_device(void)
-- 
2.20.1


             reply	other threads:[~2022-08-02  9:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  9:55 Pali Rohár [this message]
2022-08-02 21:50 ` [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method Tony Dinh
2022-08-02 22:00   ` Pali Rohár
2022-08-02 22:13     ` Tony Dinh
2022-08-03 10:24       ` Pali Rohár
2022-08-04  6:06         ` Tony Dinh
2022-08-04 23:06           ` Tony Dinh
2022-08-05 12:27             ` Pali Rohár
2022-08-03  6:48 ` Stefan Roese
2022-08-09 11:33 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802095519.17352-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=mibodhi@gmail.com \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox